Invalidate inpcb LLE cache if cached route is invalidated
ClosedPublic
Actions

Authored by rstone on Jan 19 2018, 9:40 PM.

Details

Reviewers

Commits

rS328270: Invalidate inpcb LLE cache if cached route is invalidated

Summary

When the inpcb route cache is invalidated after a change to the
routing tables, we need to invalidate the LLE cache as well.
Previous to this change packets for the connection would continue
to use the old L2 information from the old L3 gateway, and the
packets for the connection would likely be blackholed.

MFC after: 1 week
Sponsored by: Dell EMC Isilon

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

rstone created this revision.Jan 19 2018, 9:40 PM

Herald added a subscriber: ae. · View Herald TranscriptJan 19 2018, 9:40 PM

jim_netgate.com added a subscriber: jim_netgate.com.Jan 19 2018, 10:09 PM

Could this use the new invalidate macro?

wollman added a subscriber: wollman.Jan 20 2018, 5:56 PM

In D13988#293614, @karels wrote:

Could this use the new invalidate macro?

I realized after uploading that I presented this reviews in a confusing order. First I added this change in one review, then in the second review I replaced this immediately with the invalidate macro. Sorry about that, but yes, the invalidate macro can be used here and I did make that change in the other review.

Got it. I didn't realize it, but Phabricator lists the reviews in reverse order, so that's the order I looked at them.

• karels accepted this revision.Jan 22 2018, 5:38 AM

This revision is now accepted and ready to land.Jan 22 2018, 5:38 AM

Closed by commit rS328270: Invalidate inpcb LLE cache if cached route is invalidated (authored by rstone). · Explain WhyJan 23 2018, 3:15 AM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJan 23 2018, 3:15 AM