Support for UART device on Qualcomm Snapdragon 410e
ClosedPublic
Actions

Authored by br on Jan 18 2018, 5:04 PM.

Details

Reviewers

Group Reviewers

arm64
ARM

Commits

rS328132: Support for UART device found in Qualcomm Snapdragon 410E SoC.

Summary

This is a minimal set of changes required for uart_msm driver to operate on Qualcomm Snapdragon 410e (DragonBoard 410c).
I'm not sure if this changes compatible with other qualcomms, but it does not seem we have any of them in base yet.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

br created this revision.Jan 18 2018, 5:04 PM

andrew added a subscriber: andrew.Jan 18 2018, 5:07 PM

andrew added inline comments.

sys/dev/uart/uart_dev_msm.c
41 ↗	(On Diff #38170)	Why do we need this on non-arm64?

You should also add it to files.arm64 and the arm64 GENERIC config.

sys/dev/uart/uart_dev_msm.c
127 ↗	(On Diff #38170)	Shouldn't there be a switch based on baudrate to set this?

Exclude fdt.h

sys/dev/uart/uart_dev_msm.c
41 ↗	(On Diff #38170)	We don't need this currently, so removed

andrew accepted this revision.Jan 18 2018, 5:37 PM

This revision is now accepted and ready to land.Jan 18 2018, 5:37 PM

Closed by commit rS328132: Support for UART device found in Qualcomm Snapdragon 410E SoC. (authored by br). · Explain WhyJan 18 2018, 5:43 PM

This revision was automatically updated to reflect the committed changes.

Herald added a subscriber: imp. · View Herald TranscriptJan 18 2018, 5:43 PM

Revision Contents
Changeset List

Path

Size

head/

sys/

dev/

uart/

uart_dev_msm.h

5 lines

uart_dev_msm.c

19 lines

Diff 38174

View Options

head/sys/dev/uart/uart_dev_msm.h