When returning an error and freeing allocated memory from ucs2_to_utf8 and utf8_to_ucs2, be sure to NULL out the return pointer too, rather than return a pointer to free memory.
ClosedPublic
Actions

Authored by imp on Jan 15 2018, 4:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Sat, Dec 14, 3:05 PM

	Unknown Object (File)
	Sat, Dec 7, 3:02 AM

	Unknown Object (File)
	Mon, Nov 25, 12:34 AM

	Unknown Object (File)
	Fri, Nov 22, 2:55 AM

	Unknown Object (File)
	Thu, Nov 21, 3:11 PM

	Unknown Object (File)
	Nov 18 2024, 10:12 AM

	Unknown Object (File)
	Nov 18 2024, 6:11 AM

	Unknown Object (File)
	Nov 17 2024, 8:50 PM

View All 38 Files

Subscribers

None

Details

Reviewers

andrew
tsoome

Commits

rS328029: When returning an error and freeing allocated memory from ucs2_to_utf8

Diff Detail

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 14384
Build 14538: arc lint + arc unit

Event Timeline

imp created this revision.Jan 15 2018, 4:33 PM

imp added reviewers: andrew, tsoome.Jan 15 2018, 4:34 PM

tsoome accepted this revision.Jan 15 2018, 8:02 PM

This revision is now accepted and ready to land.Jan 15 2018, 8:02 PM

Closed by commit rS328029: When returning an error and freeing allocated memory from ucs2_to_utf8 (authored by imp). · Explain WhyJan 15 2018, 10:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

stand/

efi/

libefi/

efichar.c

35 lines

Diff 37974

View Options

stand/efi/libefi/efichar.c

When returning an error and freeing allocated memory from ucs2_to_utf8 and utf8_to_ucs2, be sure to NULL out the return pointer too, rather than return a pointer to free memory.ClosedPublicActions