When returning an error and freeing allocated memory from ucs2_to_utf8 and utf8_to_ucs2, be sure to NULL out the return pointer too, rather than return a pointer to free memory.
ClosedPublic
Actions

Authored by imp on Jan 15 2018, 4:33 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Thu, May 14, 1:59 AM

	Unknown Object (File)
	Tue, May 12, 6:41 AM

	Unknown Object (File)
	Sun, May 10, 2:25 AM

	Unknown Object (File)
	Fri, May 8, 9:08 PM

	Unknown Object (File)
	Fri, May 1, 10:51 PM

	Unknown Object (File)
	Thu, Apr 30, 4:09 AM

	Unknown Object (File)
	Mon, Apr 27, 1:42 PM

	Unknown Object (File)
	Sat, Apr 25, 11:50 AM

View All 88 Files

Subscribers

None

Details

Reviewers

andrew
tsoome

Commits

rS328029: When returning an error and freeing allocated memory from ucs2_to_utf8

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jan 15 2018, 4:33 PM

imp added reviewers: andrew, tsoome.Jan 15 2018, 4:34 PM

tsoome accepted this revision.Jan 15 2018, 8:02 PM

This revision is now accepted and ready to land.Jan 15 2018, 8:02 PM

Closed by commit rS328029: When returning an error and freeing allocated memory from ucs2_to_utf8 (authored by imp). · Explain WhyJan 15 2018, 10:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

efi/

libefi/

efichar.c

35 lines

Diff 38000

View Options

head/stand/efi/libefi/efichar.c

When returning an error and freeing allocated memory from ucs2_to_utf8 and utf8_to_ucs2, be sure to NULL out the return pointer too, rather than return a pointer to free memory.ClosedPublicActions