When returning an error and freeing allocated memory from ucs2_to_utf8 and utf8_to_ucs2, be sure to NULL out the return pointer too, rather than return a pointer to free memory.
ClosedPublic
Actions

Authored by imp on Jan 15 2018, 4:33 PM.

Tags

None

Referenced Files

	F171402871: D13917.id37974.diff
	Thu, Sep 10, 10:39 PM

	Unknown Object (File)
	Tue, Sep 8, 5:59 PM

	Unknown Object (File)
	Sun, Sep 6, 7:49 PM

	Unknown Object (File)
	Sun, Sep 6, 3:39 PM

	Unknown Object (File)
	Sun, Sep 6, 4:39 AM

	Unknown Object (File)
	Sat, Sep 5, 11:35 PM

	Unknown Object (File)
	Fri, Sep 4, 5:41 AM

	Unknown Object (File)
	Thu, Sep 3, 11:40 PM

View All Files

Subscribers

None

Details

Reviewers

andrew
tsoome

Commits

rS328029: When returning an error and freeing allocated memory from ucs2_to_utf8

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

imp created this revision.Jan 15 2018, 4:33 PM

imp added reviewers: andrew, tsoome.Jan 15 2018, 4:34 PM

tsoome accepted this revision.Jan 15 2018, 8:02 PM

This revision is now accepted and ready to land.Jan 15 2018, 8:02 PM

Closed by commit rS328029: When returning an error and freeing allocated memory from ucs2_to_utf8 (authored by imp). · Explain WhyJan 15 2018, 10:17 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

stand/

efi/

libefi/

efichar.c

35 lines

Diff 38000

View Options

head/stand/efi/libefi/efichar.c

When returning an error and freeing allocated memory from ucs2_to_utf8 and utf8_to_ucs2, be sure to NULL out the return pointer too, rather than return a pointer to free memory.ClosedPublicActions