Page MenuHomeFreeBSD

sysutils/xorriso: make TK frontend optional
Needs ReviewPublic

Authored by fabian.freyer_physik.tu-berlin.de on Jan 12 2018, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 2:38 PM
Unknown Object (File)
Wed, Dec 11, 2:52 AM
Unknown Object (File)
Nov 27 2024, 7:58 AM
Unknown Object (File)
Oct 29 2024, 9:30 PM
Unknown Object (File)
Oct 29 2024, 9:27 PM
Unknown Object (File)
Oct 23 2024, 5:04 PM
Unknown Object (File)
Oct 20 2024, 8:02 PM
Unknown Object (File)
Oct 19 2024, 2:42 PM
This revision needs review, but there are no reviewers specified.

Details

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This patch won't apply cleanly for me, can you please recreate it?

Sure, I don't know why it didn't work for you though. I recreated it with full context.

sysutils/xorriso/Makefile
19–24

Out of order. See Chapter 15. Order of Variables in Port Makefiles.
These should go after the INFO variable definition.

fabian.freyer_physik.tu-berlin.de marked an inline comment as done.

@mat, thanks for catching that! I updated the patch, and also bumped PORTREVISION.

sysutils/xorriso/Makefile
37–38

This should probably be post-install-TK-off:. Or even better, it should not be built and not installed at all :-)

sysutils/xorriso/Makefile
18–19

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

sysutils/xorriso/Makefile
18–19

I guess while I'm here I could also fix that :)