Page MenuHomeFreeBSD

sysutils/xorriso: make TK frontend optional
Needs ReviewPublic

Authored by fabian.freyer_physik.tu-berlin.de on Jan 12 2018, 8:09 PM.
Tags
None
Referenced Files
F99152003: D13891.diff
Sun, Oct 6, 9:03 PM
F99107782: D13891.diff
Sun, Oct 6, 12:25 PM
Unknown Object (File)
Thu, Oct 3, 10:52 AM
Unknown Object (File)
Wed, Oct 2, 5:33 PM
Unknown Object (File)
Wed, Oct 2, 12:22 AM
Unknown Object (File)
Mon, Sep 30, 3:13 PM
Unknown Object (File)
Fri, Sep 27, 8:50 AM
Unknown Object (File)
Tue, Sep 24, 6:54 AM
This revision needs review, but there are no reviewers specified.

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This patch won't apply cleanly for me, can you please recreate it?

Sure, I don't know why it didn't work for you though. I recreated it with full context.

sysutils/xorriso/Makefile
20–25

Out of order. See Chapter 15. Order of Variables in Port Makefiles.
These should go after the INFO variable definition.

fabian.freyer_physik.tu-berlin.de marked an inline comment as done.

@mat, thanks for catching that! I updated the patch, and also bumped PORTREVISION.

sysutils/xorriso/Makefile
38–39

This should probably be post-install-TK-off:. Or even better, it should not be built and not installed at all :-)

sysutils/xorriso/Makefile
20

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

sysutils/xorriso/Makefile
20

I guess while I'm here I could also fix that :)