Page MenuHomeFreeBSD

sysutils/xorriso: make TK frontend optional
Needs ReviewPublic

Authored by fabian.freyer_physik.tu-berlin.de on Jan 12 2018, 8:09 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Apr 9, 2:57 AM
Unknown Object (File)
Mon, Apr 8, 4:15 AM
Unknown Object (File)
Feb 19 2024, 10:35 AM
Unknown Object (File)
Feb 11 2024, 8:56 AM
Unknown Object (File)
Dec 30 2023, 2:36 AM
Unknown Object (File)
Dec 20 2023, 7:01 AM
Unknown Object (File)
Dec 10 2023, 10:25 PM
Unknown Object (File)
Nov 21 2023, 3:49 AM
This revision needs review, but there are no reviewers specified.

Details

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

This patch won't apply cleanly for me, can you please recreate it?

Sure, I don't know why it didn't work for you though. I recreated it with full context.

sysutils/xorriso/Makefile
19–24

Out of order. See Chapter 15. Order of Variables in Port Makefiles.
These should go after the INFO variable definition.

fabian.freyer_physik.tu-berlin.de marked an inline comment as done.

@mat, thanks for catching that! I updated the patch, and also bumped PORTREVISION.

sysutils/xorriso/Makefile
37–38

This should probably be post-install-TK-off:. Or even better, it should not be built and not installed at all :-)

sysutils/xorriso/Makefile
18–19

Wrong place in the Makefile. See Chapter 15. Order of Variables in Port Makefiles.

sysutils/xorriso/Makefile
18–19

I guess while I'm here I could also fix that :)