Page MenuHomeFreeBSD

Fix databases/soci build w/ clang.
ClosedPublic

Authored by adridg on Jan 4 2018, 8:39 PM.

Details

Summary

Add upstream patch that fixes bogus pointer-vs-int comparison.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

adridg created this revision.Jan 4 2018, 8:39 PM
adridg updated this revision to Diff 37530.Jan 4 2018, 8:41 PM

Come to think of it, if this previously compiled, the comparison
would be wrong and it's a bug which can mis-report an error.
While here, drop the BROKEN lines, since this fixes exactly that error.

tcberner accepted this revision.Jan 4 2018, 9:12 PM

Looks good from my side.

This revision is now accepted and ready to land.Jan 4 2018, 9:12 PM
jlaffaye accepted this revision.Jan 5 2018, 7:50 AM

LGTM

This revision was automatically updated to reflect the committed changes.