Page MenuHomeFreeBSD
Differential D13765

Fix audio/sayonara build on 10.3 i386
ClosedPublic
Actions

Authored by adridg on Jan 4 2018, 12:27 PM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 30 2024, 10:22 PM
Unknown Object (File)
Nov 29 2024, 2:04 PM
Unknown Object (File)
Nov 26 2024, 2:21 PM
Unknown Object (File)
Nov 26 2024, 12:24 AM
Unknown Object (File)
Nov 19 2024, 5:38 AM
Unknown Object (File)
Nov 4 2024, 10:05 AM
Unknown Object (File)
Nov 1 2024, 1:03 PM
Unknown Object (File)
Oct 27 2024, 6:21 PM
View All 85 Files
Subscribers
mat

Details

Reviewers
tcberner
rakuco
Commits
rP458026: Fix build on 10.3 i386 noticed by pkg-fallout. Patch has also been
Summary

Missing include; needed for std::abs

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 14107
Build 14284: arc lint + arc unit

Event Timeline

adridg created this revision.Jan 4 2018, 12:27 PM
Herald added a subscriber: mat. · View Herald TranscriptJan 4 2018, 12:27 PM
Harbormaster completed remote builds in B14107: Diff 37507.Jan 4 2018, 12:27 PM
rakuco accepted this revision.Jan 4 2018, 12:30 PM

In this case, you don't need to bump PORTREVISION: the file being patched is not installed, the generated code should remain mostly the same and the build isn't really changed in the platforms where it was already working before.

This revision is now accepted and ready to land.Jan 4 2018, 12:30 PM
adridg updated this revision to Diff 37508.Jan 4 2018, 12:39 PM

No need for PORTREVISION bump, this is fixing build on i386
that didn't build before.

This revision now requires review to proceed.Jan 4 2018, 12:39 PM
Harbormaster completed remote builds in B14108: Diff 37508.Jan 4 2018, 12:39 PM
This revision was not accepted when it landed; it landed in state Needs Review.Jan 4 2018, 12:48 PM
Closed by commit rP458026: Fix build on 10.3 i386 noticed by pkg-fallout. Patch has also been (authored by adridg). · Explain Why
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Diff 37507

View Options

audio/sayonara/Makefile

Loading...
View Options

audio/sayonara/files/

Loading...
View Options

audio/sayonara/files/patch-src_Components_Engine_AbstractEngine.cpp

Loading...