Fix audio/sayonara build on 10.3 i386
ClosedPublic
Actions

Authored by adridg on Jan 4 2018, 12:27 PM.

Details

Reviewers

tcberner
rakuco

Commits

rP458026: Fix build on 10.3 i386 noticed by pkg-fallout. Patch has also been

Summary

Missing include; needed for std::abs

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adridg created this revision.Jan 4 2018, 12:27 PM

Herald added a subscriber: mat. · View Herald TranscriptJan 4 2018, 12:27 PM

Harbormaster completed remote builds in B14107: Diff 37507.Jan 4 2018, 12:27 PM

In this case, you don't need to bump PORTREVISION: the file being patched is not installed, the generated code should remain mostly the same and the build isn't really changed in the platforms where it was already working before.

This revision is now accepted and ready to land.Jan 4 2018, 12:30 PM

No need for PORTREVISION bump, this is fixing build on i386
that didn't build before.

This revision now requires review to proceed.Jan 4 2018, 12:39 PM

Harbormaster completed remote builds in B14108: Diff 37508.Jan 4 2018, 12:39 PM

This revision was not accepted when it landed; it landed in state Needs Review.Jan 4 2018, 12:48 PM

Closed by commit rP458026: Fix build on 10.3 i386 noticed by pkg-fallout. Patch has also been (authored by adridg). · Explain Why

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

audio/

sayonara/

files/

patch-src_Components_Engine_AbstractEngine.cpp

13 lines

Diff 37511

View Options

head/audio/sayonara/files/patch-src_Components_Engine_AbstractEngine.cpp

Fix audio/sayonara build on 10.3 i386ClosedPublicActions