Avoid re-check of usermode condition.
ClosedPublic
Actions

Authored by kib on Jan 1 2018, 7:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Nov 21, 2:49 AM

	Unknown Object (File)
	Fri, Nov 21, 2:32 AM

	Unknown Object (File)
	Fri, Nov 21, 2:31 AM

	Unknown Object (File)
	Fri, Nov 21, 2:24 AM

	Unknown Object (File)
	Fri, Nov 21, 2:22 AM

	Unknown Object (File)
	Fri, Nov 21, 2:20 AM

	Unknown Object (File)
	Fri, Nov 21, 2:20 AM

	Unknown Object (File)
	Fri, Nov 21, 2:18 AM

View All Files

Subscribers

imp

Details

Reviewers

alc

Commits

rS327472: Avoid re-check of usermode condition.

Summary

This change should not change anything in the behavior of trap_pfault(), while eliminating obfuscation of jumping to the code which checks for reversed condition.

Diff Detail

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

kib created this revision.Jan 1 2018, 7:54 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 1 2018, 7:54 PM

kib added a reviewer: alc.Jan 1 2018, 7:55 PM

Fix amd64 portion of the patch.

alc added inline comments.Jan 1 2018, 8:17 PM

sys/amd64/amd64/trap.c
662	The unconditional initialization of the variable "rv" to zero is now redundant. Arguably, zero was never a value of the correct type for its initialization, because it's not a KERN_*.