Page MenuHomeFreeBSD

Avoid re-check of usermode condition.
ClosedPublic

Authored by kib on Jan 1 2018, 7:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Jan 22 2024, 2:53 AM
Unknown Object (File)
Jan 7 2024, 10:39 AM
Unknown Object (File)
Dec 14 2023, 6:48 PM
Unknown Object (File)
Dec 2 2023, 7:58 AM
Unknown Object (File)
Nov 18 2023, 12:43 PM
Unknown Object (File)
Nov 16 2023, 3:07 PM
Unknown Object (File)
Nov 6 2023, 4:35 PM
Unknown Object (File)
Oct 5 2023, 3:31 PM
Subscribers

Details

Summary

This change should not change anything in the behavior of trap_pfault(), while eliminating obfuscation of jumping to the code which checks for reversed condition.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped
Build Status
Buildable 14039

Event Timeline

Fix amd64 portion of the patch.

sys/amd64/amd64/trap.c
663

The unconditional initialization of the variable "rv" to zero is now redundant. Arguably, zero was never a value of the correct type for its initialization, because it's not a KERN_*.

Remove initialization of rv.

This revision is now accepted and ready to land.Jan 1 2018, 8:25 PM
This revision was automatically updated to reflect the committed changes.