Avoid re-check of usermode condition.
ClosedPublic
Actions

Authored by kib on Jan 1 2018, 7:54 PM.

Tags

None

Referenced Files

	F166950471: D13725.diff
	Tue, Aug 18, 1:34 AM

	F166943315: D13725.id37367.diff
	Mon, Aug 17, 11:16 PM

	F166905438: D13725.id37366.diff
	Mon, Aug 17, 4:24 PM

	F166903696: D13725.diff
	Mon, Aug 17, 4:04 PM

	F166895750: D13725.id37368.diff
	Mon, Aug 17, 2:38 PM

	F166883246: D13725.id37372.diff
	Mon, Aug 17, 12:28 PM

	Unknown Object (File)
	Sun, Aug 16, 9:55 PM

	Unknown Object (File)
	Sun, Aug 16, 8:41 PM

View All Files

Subscribers

imp

Details

Reviewers

alc

Commits

rS327472: Avoid re-check of usermode condition.

Summary

This change should not change anything in the behavior of trap_pfault(), while eliminating obfuscation of jumping to the code which checks for reversed condition.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jan 1 2018, 7:54 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 1 2018, 7:54 PM

kib added a reviewer: alc.Jan 1 2018, 7:55 PM

Fix amd64 portion of the patch.

alc added inline comments.Jan 1 2018, 8:17 PM

sys/amd64/amd64/trap.c
663 ↗	(On Diff #37366)	The unconditional initialization of the variable "rv" to zero is now redundant. Arguably, zero was never a value of the correct type for its initialization, because it's not a KERN_*.