Avoid re-check of usermode condition.
ClosedPublic
Actions

Authored by kib on Jan 1 2018, 7:54 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Fri, Jul 17, 5:33 PM

	Unknown Object (File)
	Tue, Jul 7, 2:24 PM

	Unknown Object (File)
	Sun, Jul 5, 12:30 PM

	Unknown Object (File)
	Sun, Jul 5, 6:32 AM

	Unknown Object (File)
	Fri, Jul 3, 2:35 PM

	Unknown Object (File)
	Jun 7 2026, 10:58 PM

	Unknown Object (File)
	Apr 29 2026, 1:59 AM

	Unknown Object (File)
	Apr 21 2026, 11:13 PM

View All Files

Subscribers

imp

Details

Reviewers

alc

Commits

rS327472: Avoid re-check of usermode condition.

Summary

This change should not change anything in the behavior of trap_pfault(), while eliminating obfuscation of jumping to the code which checks for reversed condition.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jan 1 2018, 7:54 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 1 2018, 7:54 PM

kib added a reviewer: alc.Jan 1 2018, 7:55 PM

Fix amd64 portion of the patch.

alc added inline comments.Jan 1 2018, 8:17 PM

sys/amd64/amd64/trap.c
663 ↗	(On Diff #37366)	The unconditional initialization of the variable "rv" to zero is now redundant. Arguably, zero was never a value of the correct type for its initialization, because it's not a KERN_*.