Avoid re-check of usermode condition.
ClosedPublic
Actions

Authored by kib on Jan 1 2018, 7:54 PM.

Tags

None

Referenced Files

	F170915330: D13725.id37372.diff
	Mon, Sep 7, 1:36 PM

	F170912515: D13725.id37366.diff
	Mon, Sep 7, 1:03 PM

	F170912016: D13725.id37368.diff
	Mon, Sep 7, 12:57 PM

	F170911477: D13725.id37367.diff
	Mon, Sep 7, 12:51 PM

	Unknown Object (File)
	Sun, Aug 23, 4:49 AM

	Unknown Object (File)
	Fri, Aug 21, 3:43 PM

	Unknown Object (File)
	Fri, Aug 21, 11:39 AM

	Unknown Object (File)
	Wed, Aug 19, 6:40 PM

View All Files

Subscribers

imp

Details

Reviewers

alc

Commits

rS327472: Avoid re-check of usermode condition.

Summary

This change should not change anything in the behavior of trap_pfault(), while eliminating obfuscation of jumping to the code which checks for reversed condition.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Jan 1 2018, 7:54 PM

Herald added a subscriber: imp. · View Herald TranscriptJan 1 2018, 7:54 PM

kib added a reviewer: alc.Jan 1 2018, 7:55 PM

Fix amd64 portion of the patch.

alc added inline comments.Jan 1 2018, 8:17 PM

sys/amd64/amd64/trap.c
663 ↗	(On Diff #37366)	The unconditional initialization of the variable "rv" to zero is now redundant. Arguably, zero was never a value of the correct type for its initialization, because it's not a KERN_*.