New port: graphics/pcl-pointclouds: Point Cloud Library

[yuri]

Summary

Point Cloud Library

[yuri]

There is another port named pcl, devel/pcl, hence PKGNAMESUFFIX=-pointclouds.

[adamw]

In D13697#286417, @yuri wrote:

There is another port named pcl, devel/pcl, hence PKGNAMESUFFIX=-pointclouds.

You need to be modifying the pkg name, not the version. make -V PKGBASE *must* be unique. Use PKGNAMEPREFIX or SUFFIX. Plus, "pcl-pcl" doesn't in any way identify which pcl port this is. You're better off naming it "pcl-graphics" or something like that.

[yuri]

In D13697#286436, @adamw wrote:

In D13697#286417, @yuri wrote:

There is another port named pcl, devel/pcl, hence PKGNAMESUFFIX=-pointclouds.

You need to be modifying the pkg name, not the version. make -V PKGBASE *must* be unique. Use PKGNAMEPREFIX or SUFFIX. Plus, "pcl-pcl" doesn't in any way identify which pcl port this is. You're better off naming it "pcl-graphics" or something like that.

PKGNAMESUFFIX is what I used: PKGNAMESUFFIX=-pointclouds.

$ make -V PKGBASE
pcl-pointclouds

[tcberner]

In D13697#286441, @yuri wrote:

In D13697#286436, @adamw wrote:

In D13697#286417, @yuri wrote:

There is another port named pcl, devel/pcl, hence PKGNAMESUFFIX=-pointclouds.

You need to be modifying the pkg name, not the version. make -V PKGBASE *must* be unique. Use PKGNAMEPREFIX or SUFFIX. Plus, "pcl-pcl" doesn't in any way identify which pcl port this is. You're better off naming it "pcl-graphics" or something like that.

PKGNAMESUFFIX is what I used: PKGNAMESUFFIX=-pointclouds.

$ make -V PKGBASE
pcl-pointclouds

But you wrote

There is another port named `pcl`, `devel/pcl`, hence `DISTVERSIONPREFIX=${PORTNAME}-`.

:)

[yuri]

In D13697#286442, @tcberner wrote:

In D13697#286441, @yuri wrote:

In D13697#286436, @adamw wrote:

In D13697#286417, @yuri wrote:

There is another port named pcl, devel/pcl, hence PKGNAMESUFFIX=-pointclouds.

You need to be modifying the pkg name, not the version. make -V PKGBASE *must* be unique. Use PKGNAMEPREFIX or SUFFIX. Plus, "pcl-pcl" doesn't in any way identify which pcl port this is. You're better off naming it "pcl-graphics" or something like that.

PKGNAMESUFFIX is what I used: PKGNAMESUFFIX=-pointclouds.

$ make -V PKGBASE
pcl-pointclouds

But you wrote

There is another port named `pcl`, `devel/pcl`, hence `DISTVERSIONPREFIX=${PORTNAME}-`.

:)

Sorry, this was a typo the first time. Copy-paste from a wrong line. :-)
I corrected it right after posting a comment.

[tcberner]

graphics/pcl/Makefile

15 ↗

(On Diff #37253)

USES=eigen:3

[yuri]

eigen:3

[tcberner]

graphics/Makefile

760 ↗

(On Diff #37655)

to me it woudl be preferable if the ports directory were pcl-pointclouds

[yuri]

Renamed.

[yuri]

Directory has been renamed.

[mat]

graphics/pcl-pointclouds/pkg-plist

1080–1081 ↗

(On Diff #37700)

This is wrong. DATADIR is a *directory*. Set DATADIR in the Makefile to the correct value.

[yuri]

graphics/pcl-pointclouds/pkg-plist

1080–1081 ↗

(On Diff #37700)

Changed DATADIR to reflect where the project installs .cmake files.
Also, verified that these .cmake files actually work.