Page MenuHomeFreeBSD

New port: graphics/pcl-pointclouds: Point Cloud Library
ClosedPublic

Authored by yuri on Dec 30 2017, 9:49 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Jun 18, 7:11 PM
Unknown Object (File)
Mon, Jun 17, 5:44 PM
Unknown Object (File)
May 17 2024, 10:52 AM
Unknown Object (File)
May 17 2024, 10:52 AM
Unknown Object (File)
May 17 2024, 10:52 AM
Unknown Object (File)
May 17 2024, 10:52 AM
Unknown Object (File)
May 17 2024, 10:52 AM
Unknown Object (File)
May 17 2024, 10:40 AM
Subscribers

Details

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13957
Build 14151: arc lint + arc unit

Event Timeline

There is another port named pcl, devel/pcl, hence PKGNAMESUFFIX=-pointclouds.

In D13697#286417, @yuri wrote:

There is another port named pcl, devel/pcl, hence PKGNAMESUFFIX=-pointclouds.

You need to be modifying the pkg name, not the version. make -V PKGBASE *must* be unique. Use PKGNAMEPREFIX or SUFFIX. Plus, "pcl-pcl" doesn't in any way identify which pcl port this is. You're better off naming it "pcl-graphics" or something like that.

In D13697#286417, @yuri wrote:

There is another port named pcl, devel/pcl, hence PKGNAMESUFFIX=-pointclouds.

You need to be modifying the pkg name, not the version. make -V PKGBASE *must* be unique. Use PKGNAMEPREFIX or SUFFIX. Plus, "pcl-pcl" doesn't in any way identify which pcl port this is. You're better off naming it "pcl-graphics" or something like that.

PKGNAMESUFFIX is what I used: PKGNAMESUFFIX=-pointclouds.

$ make -V PKGBASE
pcl-pointclouds

In D13697#286441, @yuri wrote:
In D13697#286417, @yuri wrote:

There is another port named pcl, devel/pcl, hence PKGNAMESUFFIX=-pointclouds.

You need to be modifying the pkg name, not the version. make -V PKGBASE *must* be unique. Use PKGNAMEPREFIX or SUFFIX. Plus, "pcl-pcl" doesn't in any way identify which pcl port this is. You're better off naming it "pcl-graphics" or something like that.

PKGNAMESUFFIX is what I used: PKGNAMESUFFIX=-pointclouds.

$ make -V PKGBASE
pcl-pointclouds

But you wrote

There is another port named `pcl`, `devel/pcl`, hence `DISTVERSIONPREFIX=${PORTNAME}-`.

:)

In D13697#286441, @yuri wrote:
In D13697#286417, @yuri wrote:

There is another port named pcl, devel/pcl, hence PKGNAMESUFFIX=-pointclouds.

You need to be modifying the pkg name, not the version. make -V PKGBASE *must* be unique. Use PKGNAMEPREFIX or SUFFIX. Plus, "pcl-pcl" doesn't in any way identify which pcl port this is. You're better off naming it "pcl-graphics" or something like that.

PKGNAMESUFFIX is what I used: PKGNAMESUFFIX=-pointclouds.

$ make -V PKGBASE
pcl-pointclouds

But you wrote

There is another port named `pcl`, `devel/pcl`, hence `DISTVERSIONPREFIX=${PORTNAME}-`.

:)

Sorry, this was a typo the first time. Copy-paste from a wrong line. :-)
I corrected it right after posting a comment.

tcberner requested changes to this revision.Jan 8 2018, 8:56 PM
tcberner added inline comments.
graphics/pcl/Makefile
15

USES=eigen:3

This revision now requires changes to proceed.Jan 8 2018, 8:56 PM
yuri marked an inline comment as done.Jan 8 2018, 10:04 PM
graphics/Makefile
759

to me it woudl be preferable if the ports directory were pcl-pointclouds

yuri retitled this revision from New port: graphics/pcl: Point Cloud Library to New port: graphics/pcl-pointclouds: Point Cloud Library.Jan 9 2018, 11:49 PM
yuri marked an inline comment as done.

Directory has been renamed.

This revision is now accepted and ready to land.Jan 15 2018, 12:31 PM
graphics/pcl-pointclouds/pkg-plist
1080–1081 ↗(On Diff #37700)

This is wrong. DATADIR is a *directory*. Set DATADIR in the Makefile to the correct value.

yuri marked an inline comment as done.Jan 16 2018, 5:53 AM
yuri added inline comments.
graphics/pcl-pointclouds/pkg-plist
1080–1081 ↗(On Diff #37700)

Changed DATADIR to reflect where the project installs .cmake files.
Also, verified that these .cmake files actually work.

This revision was automatically updated to reflect the committed changes.
yuri marked an inline comment as done.