Page MenuHomeFreeBSD

stand/fdt: Make fdt_overlay_apply signature-compatible with libfdt
ClosedPublic

Authored by kevans on Dec 30 2017, 3:51 PM.

Details

Summary

libfdt will assume a writable fdt overlay blob has been passed in, so make ours compatible to allow easier review when we try to drop libfdt into place. overlay from the calling context is writable, making it safe to simply rip out everything related to copying the overlay blob in fdt_overlay_apply.

I note here that we still have problems: fdt_overlay_apply, both our version and libfdt's, may fail and have already clobbered the base fdt to some extent. Future work will make sure we don't apply a potentially bogus fdt, instead discarding the base fdt if we had an error.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kevans created this revision.Dec 30 2017, 3:51 PM
gonzo accepted this revision.Dec 31 2017, 12:01 AM

LGTM

This revision is now accepted and ready to land.Dec 31 2017, 12:01 AM
This revision was automatically updated to reflect the committed changes.