Add a commit template for git commit logs

[jrm]

Summary

To use the template, see the comments in the file.

[mat]

You should probably add the instructions on how to use it in the file itself.

[krion]

Shouldn't it be: "git config commit.template .gitmessage" ?

[krion]

In D13677#286176, @mat wrote:

You should probably add the instructions on how to use it in the file itself.

I agree. It would make sense to put here how-to hook commit-msg with appropriate location and permissions.

[jrm]

• Describe how to use the git commit template in the template itself

[krion]

Looks good now, imo.

[krion]

It seems it doesn't remove empty lines, see:
https://svnweb.freebsd.org/ports?view=revision&revision=457638

[eadler]

Consider just leaving the comment and letting users uncomment lines they want.

[jrm]

Fix commit-msg hook and tweak instructions in git commit template

[mat]

.gitmessage

38–54 ↗

(On Diff #37267)

Empty fields are already removed by a hook in the repository.

[jrm]

.gitmessage

38–54 ↗

(On Diff #37267)

I assumed this was (only) implemented in the svn clients we use, based on cleanmsg().

• https://svnweb.freebsd.org/ports/head/devel/subversion/files/extra-patch-fbsd-template?revision=411397&view=markup
• https://svnweb.freebsd.org/base/head/contrib/subversion/subversion/svn/util.c?revision=298996&view=markup

In any case, one first has to commit to git. Would it not be nice for empty fields to be cleaned automatically for the git commits?

[jrm]

• Fix path to commit-msg hook in git commit template comments

[mat]

There is no such thing as a "git commit". Commits in git repositories are only transient, and they only last as long as it takes you to commit them to the Subversion repository.

Commit messages are cleaned up by svnadmin/hooks/scripts/log-police.py. So, really, I see no reason to clobber the template with 2. and after.

[jrm]

• Remove the comments describing the git commit-msg hook

[mat]

head/.gitattributes

1

Mmmm, I do not understand, will there be more tha one .gitmessage file ?

[jrm]

head/.gitattributes

1

This was not really intended. It would only let me git dcommit after git svn propset.., which adds a line to .gitattributes.
What was the right solution here? Committing directly with svn, or maybe adding a line to ~/.subversion/config?

Shall I remove the line?

[mat]

head/.gitattributes

1

Mmmm, I think you should commit it with svn directly, I don't see a good way to do it with git without this spam here :/

(Also, try not to add stuff to ~/.subversion/config, it only mostly confuses things.)