Set vnet when calling pru_sockaddr and pru_peeraddr
ClosedPublic
Actions

Authored by tuexen on Dec 27 2017, 2:51 PM.

Details

Reviewers

bz
gnn

Group Reviewers

transport

Commits

rS327844: Ensure that the vnet is set when calling pru_sockaddr() and

Summary

When pru_sockaddr is called from kern_getsockname(), the vnet is set. This is also true when pru_peeraddr is called via kern_getpeername(). However, the vnet is not net when these functions are called from soo_fill_kinfo(). This patch ensures that the vnet is also set in this case.

The corresponding SCTP functions assume the vnet to be set correctly. Right now, when a program with an wildcard bound SCTP socket crashes, the machines panics when trying to write the core file.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tuexen created this revision.Dec 27 2017, 2:51 PM

Herald added a subscriber: imp. · View Herald TranscriptDec 27 2017, 2:51 PM

Seems this came in in r271976 with D775 after VIMAGE was in the tree.
You don't need to set the CURVNET() that early (only after the switch) it seems but it shouldn't matter.
Looks OK to me.

This revision is now accepted and ready to land.Jan 11 2018, 6:06 PM

Closed by commit rS327844: Ensure that the vnet is set when calling pru_sockaddr() and (authored by tuexen). · Explain WhyJan 11 2018, 8:26 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

sys/

kern/

sys_socket.c

2 lines

Diff 37841

View Options

head/sys/kern/sys_socket.c

Set vnet when calling pru_sockaddr and pru_peeraddrClosedPublicActions