Page MenuHomeFreeBSD

Make webkit optional in qt5-designer
ClosedPublic

Authored by tcberner on Dec 26 2017, 4:25 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Dec 11, 8:25 AM
Unknown Object (File)
Thu, Dec 5, 6:25 PM
Unknown Object (File)
Sun, Dec 1, 10:26 AM
Unknown Object (File)
Nov 2 2024, 10:45 PM
Unknown Object (File)
Nov 2 2024, 10:45 PM
Unknown Object (File)
Nov 2 2024, 10:45 PM
Unknown Object (File)
Nov 2 2024, 10:45 PM
Unknown Object (File)
Nov 2 2024, 10:45 PM
Subscribers

Details

Reviewers
rakuco
Group Reviewers
kde
Commits
rP457546: Make webkit optional in qt5-designer
Summary

At the moment QtCreator depends on both webkit and webengine.

It's probably sensible to follow D13630 and get rid of the webkit dependency by default.

I chose an option here, as maybe some people would like to have the designer component available still.

Opinions?

Test Plan

... test it :)

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13840
Build 14053: arc lint + arc unit

Event Timeline

rakuco added inline comments.
devel/qt5-designer/Makefile
26

You need to redefine the description for the WEBKIT option to something meaningful to the port as well.

devel/qt5-designer/files/patch-src_designer_src_plugins_plugins.pro
1

Some context is always welcome :)

8

It's a good idea to indent this line as well as it makes the block easier to read.

Beautify the patch and add DESC.

lgtm, no need to update the patch here if you fix the typo I pointed out.

devel/qt5-designer/Makefile
28

WebKit-based

This revision is now accepted and ready to land.Dec 26 2017, 6:53 PM
This revision was automatically updated to reflect the committed changes.