Page MenuHomeFreeBSD

devel/qt5-assistant: Drop dependency on www/qt5-webkit
ClosedPublic

Authored by rakuco on Dec 25 2017, 11:37 PM.

Details

Reviewers
tcberner
Group Reviewers
kde
Commits
rP457276: Drop dependency on www/qt5-webkit.
Summary

Reduce qt5-assistant's dependency tree by dropping the dependency on QtWebKit. Instead, use qt5-widgets' QTextBrowser to render documentation. An added bonus is that with this change www/qt5-webengine no longer depends on www/qt5-webkit.

Test Plan

assistant still runs and renders pages fine. Rendering is slightly worse, but everything is still readable.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

rakuco created this revision.Dec 25 2017, 11:37 PM
tcberner accepted this revision.Dec 26 2017, 9:51 AM
tcberner added a subscriber: tcberner.

Seems like a good idea.

This revision is now accepted and ready to land.Dec 26 2017, 9:51 AM
This revision was automatically updated to reflect the committed changes.