Paths

Table of Contentst

Differential D13641

Make webkit optional in qt5-designer
ClosedPublic
Actions

Authored by tcberner on Dec 26 2017, 4:25 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Dec 11, 8:25 AM

	Unknown Object (File)
	Thu, Dec 5, 6:25 PM

	Unknown Object (File)
	Sun, Dec 1, 10:26 AM

	Unknown Object (File)
	Nov 2 2024, 10:45 PM

	Unknown Object (File)
	Nov 2 2024, 10:45 PM

	Unknown Object (File)
	Nov 2 2024, 10:45 PM

	Unknown Object (File)
	Nov 2 2024, 10:45 PM

	Unknown Object (File)
	Nov 2 2024, 10:45 PM

View All 95 Files

Subscribers

Details

Reviewers

Group Reviewers

Commits

rP457546: Make webkit optional in qt5-designer

Summary

At the moment QtCreator depends on both webkit and webengine.

It's probably sensible to follow D13630 and get rid of the webkit dependency by default.

I chose an option here, as maybe some people would like to have the designer component available still.

Opinions?

Test Plan

... test it :)

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

tcberner created this revision.Dec 26 2017, 4:25 PM

Herald added a subscriber: mat. · View Herald TranscriptDec 26 2017, 4:25 PM

rakuco added a subscriber: rakuco.Dec 26 2017, 5:44 PM

rakuco added inline comments.

devel/qt5-designer/Makefile
26 ↗	(On Diff #37054)	You need to redefine the description for the `WEBKIT` option to something meaningful to the port as well.
devel/qt5-designer/files/patch-src_designer_src_plugins_plugins.pro
1 ↗	(On Diff #37054)	Some context is always welcome :)
8 ↗	(On Diff #37054)	It's a good idea to indent this line as well as it makes the block easier to read.

Beautify the patch and add DESC.

Harbormaster completed remote builds in B13843: Diff 37062.Dec 26 2017, 6:39 PM

Add some context.

Harbormaster completed remote builds in B13844: Diff 37063.Dec 26 2017, 6:42 PM

lgtm, no need to update the patch here if you fix the typo I pointed out.

devel/qt5-designer/Makefile
28 ↗	(On Diff #37063)	WebKit-based

This revision is now accepted and ready to land.Dec 26 2017, 6:53 PM

Closed by commit rP457546: Make webkit optional in qt5-designer (authored by tcberner). · Explain WhyDec 29 2017, 10:13 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

devel/

qt5-designer/

9 lines

files/

patch-src_designer_src_plugins_plugins.pro

16 lines

6 lines

Diff 37200

head/devel/qt5-designer/Makefile

Loading...

head/devel/qt5-designer/files/patch-src_designer_src_plugins_plugins.pro

Loading...

head/devel/qt5-designer/pkg-plist

Loading...