Allow use of .WAIT in the LOCAL_DIRS and LOCAL_LIB_DIRS lists.
ClosedPublic
Actions

Authored by • ian on Dec 25 2017, 7:29 PM.

Details

Reviewers

bdrewery
imp

Group Reviewers

manpages

Commits

rS327663: MFC r327439:
rS327439: Allow use of .WAIT in the LOCAL_DIRS and LOCAL_LIB_DIRS lists.

Summary

A comment in Makefile.inc1 has long stated that LOCAL_DIRS are built last, after the base system. Incremental improvements in parallel building over the years have led to LOCAL_DIRS being built in parallel with base system directories. This change allows the .WAIT directive to appear in LOCAL_DIRS and LOCAL_LIB_DIRS lists to give the user some control over parallel building of local additions.

Test Plan

Passed make universe.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

• ian created this revision.Dec 25 2017, 7:29 PM

Herald added a reviewer: manpages. · View Herald TranscriptDec 25 2017, 7:29 PM

Herald added a subscriber: emaste. · View Herald Transcript

looks totally fine. The ifs were there to keep bad dirs from getting into the SUBDIR list. Since SUBDIR supports .WAIT, this should be no worse than before. And nobody is going to call a subdir .WAIT because of other issues with that. Looks good to me.

This revision is now accepted and ready to land.Dec 31 2017, 6:00 PM

Closed by commit rS327439: Allow use of .WAIT in the LOCAL_DIRS and LOCAL_LIB_DIRS lists. (authored by • ian). · Explain WhyDec 31 2017, 6:53 PM

This revision was automatically updated to reflect the committed changes.

Nice one, thanks.