Page MenuHomeFreeBSD

audio/cuetools: update to 1.4.1
ClosedPublic

Authored by novel on Dec 24 2017, 10:17 AM.
Tags
None
Referenced Files
F82136790: D13605.id38570.diff
Thu, Apr 25, 8:32 PM
Unknown Object (File)
Tue, Apr 23, 12:42 AM
Unknown Object (File)
Sat, Apr 20, 5:45 PM
Unknown Object (File)
Fri, Apr 19, 2:03 PM
Unknown Object (File)
Tue, Apr 16, 8:29 AM
Unknown Object (File)
Feb 20 2024, 2:52 AM
Unknown Object (File)
Feb 20 2024, 2:52 AM
Unknown Object (File)
Feb 20 2024, 2:52 AM
Subscribers

Details

Reviewers
None
Group Reviewers
Ports Committers
Commits
rP460181: audio/cuetools: update to 1.4.1
Summary
  • update to 1.4.1;
  • project has moved to github, so use USE_GITHUB and update WWW;
  • remove EXAMPLES option and install cuetag.sh unconditionally;
  • take maintainership.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

jrm added inline comments.
Makefile
5

The PH suggests DISTVERSION

15

Should GNU_CONFIGURE=yes be inserted in the USES and USE_x block?

Makefile
15

Do you mean I should not use GNU_CONFIGURE at all, or that I should define it in some other place?

I kept GNU_CONFIGURE because USES= autoreconf doesn't enable it automatically (not sure what are the reasons why it doesn't btw), and I placed it after USES because here USES and GNU_CONFIGURE are about building and USE_GITHUB and GH_ACCOUNT later are about fetching. I can group it some other way though.

Makefile
15

I was just wondering about the order. @mat probably wrote all or most of the 'Order of Variables in Port Makefiles'. Maybe he will chime in.

Makefile
15

Mmmm, yes, it can go in this block, or in the next, I do not have strong feelings for GNU_CONFIGURE and HAS_CONFIGURE.

novel marked an inline comment as done.
novel added inline comments.
Makefile
15

Thanks, I'll leave it as is then.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 28 2018, 1:38 PM
This revision was automatically updated to reflect the committed changes.