Page MenuHomeFreeBSD

audio/cuetools: update to 1.4.1
ClosedPublic

Authored by novel on Dec 24 2017, 10:17 AM.

Details

Reviewers
None
Group Reviewers
Ports Committers
Commits
rP460181: audio/cuetools: update to 1.4.1
Summary
  • update to 1.4.1;
  • project has moved to github, so use USE_GITHUB and update WWW;
  • remove EXAMPLES option and install cuetag.sh unconditionally;
  • take maintainership.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

novel created this revision.Dec 24 2017, 10:17 AM
jrm added a subscriber: jrm.Jan 1 2018, 8:14 PM
jrm added inline comments.
Makefile
5 ↗(On Diff #36962)

The PH suggests DISTVERSION

15 ↗(On Diff #36962)

Should GNU_CONFIGURE=yes be inserted in the USES and USE_x block?

novel added inline comments.Jan 2 2018, 11:51 AM
Makefile
15 ↗(On Diff #36962)

Do you mean I should not use GNU_CONFIGURE at all, or that I should define it in some other place?

I kept GNU_CONFIGURE because USES= autoreconf doesn't enable it automatically (not sure what are the reasons why it doesn't btw), and I placed it after USES because here USES and GNU_CONFIGURE are about building and USE_GITHUB and GH_ACCOUNT later are about fetching. I can group it some other way though.

jrm added inline comments.Jan 2 2018, 5:01 PM
Makefile
15 ↗(On Diff #36962)

I was just wondering about the order. @mat probably wrote all or most of the 'Order of Variables in Port Makefiles'. Maybe he will chime in.

mat added inline comments.Jan 3 2018, 12:57 PM
Makefile
15 ↗(On Diff #36962)

Mmmm, yes, it can go in this block, or in the next, I do not have strong feelings for GNU_CONFIGURE and HAS_CONFIGURE.

novel updated this revision to Diff 37457.Jan 3 2018, 1:14 PM
novel marked an inline comment as done.
novel added inline comments.
Makefile
15 ↗(On Diff #36962)

Thanks, I'll leave it as is then.

This revision was not accepted when it landed; it landed in state Needs Review.Jan 28 2018, 1:38 PM
This revision was automatically updated to reflect the committed changes.