Paths

Table of Contentst

Differential D13599

devel/rapidjson: Fix clang warnings on 12.
ClosedPublic
Actions

Authored by yuri on Dec 23 2017, 9:16 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Nov 5, 10:39 AM

	Unknown Object (File)
	Sun, Nov 2, 11:42 PM

	Unknown Object (File)
	Fri, Oct 31, 5:36 AM

	Unknown Object (File)
	Fri, Oct 31, 1:35 AM

	Unknown Object (File)
	Thu, Oct 30, 4:21 PM

	Unknown Object (File)
	Mon, Oct 27, 9:09 PM

	Unknown Object (File)
	Mon, Oct 27, 1:57 AM

	Unknown Object (File)
	Tue, Oct 21, 3:28 PM

Subscribers

Details

Reviewers

tcberner
adamw

Commits

rP457707: devel/rapidjson: Fix clang warnings on 12

Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=220388

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

yuri created this revision.Dec 23 2017, 9:16 PM

Herald added a subscriber: mat. · View Herald TranscriptDec 23 2017, 9:16 PM

adamw added inline comments.Dec 23 2017, 10:23 PM

devel/rapidjson/Makefile
33 ↗	(On Diff #36951)	Are you sure you want to still define `DATADIR` and `PORTDATA` after including bsd.port.pre.mk? Usually that is included as late as possible.

tobik added a subscriber: tobik.Dec 24 2017, 4:10 PM

tobik added inline comments.

devel/rapidjson/Makefile
18 ↗	(On Diff #36951)	It builds fine on armv7 with Dimitry's patch from the PR applied, so I think BROKEN_armv7 can be removed now. http://sprunge.us/WAXU

Moved DATADIR and PORTDATA to the earlier location.

Harbormaster completed remote builds in B13770: Diff 36968.Dec 24 2017, 5:32 PM

Removed BROKEN_armv7

yuri marked an inline comment as done.Dec 24 2017, 5:33 PM

tobik mentioned this in D13712: multimedia/kodi-devel: Add GBM flavor and prepare for Wayland support.Dec 31 2017, 12:55 PM

@adamw @tcberner Can you approve? This blocks having a package for kodi-devel on 12.0-CURRENT.

tcberner added inline comments.Dec 31 2017, 2:56 PM

devel/rapidjson/Makefile
40 ↗	(On Diff #36969)	^ why is this here and not further up i the Makefile? Also, you can write this as `CMAKE_OFF= RAPIDJSON_BUILD_TESTS` now :D

Apart from that, it is fine.

This revision is now accepted and ready to land.Dec 31 2017, 3:31 PM

yuri marked an inline comment as done.Dec 31 2017, 5:02 PM

Closed by commit rP457707: devel/rapidjson: Fix clang warnings on 12 (authored by yuri). · Explain WhyDec 31 2017, 5:14 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

devel/

rapidjson/

25 lines

6 lines

files/

patch-include_rapidjson_schema.h

10 lines

Diff 37315

head/devel/rapidjson/Makefile

Loading...

head/devel/rapidjson/distinfo

Loading...

head/devel/rapidjson/files/patch-include_rapidjson_schema.h

Loading...