Page MenuHomeFreeBSD

Reverse the check to allocate the buffer if cached pointer is NULL.
ClosedPublic

Authored by kan on Dec 23 2017, 4:41 PM.

Details

Summary

The code previously would allocate the buffer only it if were NOT
NULL. Otherwise it would happily pass NULL pointer to copyinstr
function below.

Diff Detail

Repository
rS FreeBSD src repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

kan created this revision.Dec 23 2017, 4:41 PM
kan set the repository for this revision to rS FreeBSD src repository.
kib accepted this revision.Dec 23 2017, 5:02 PM
This revision is now accepted and ready to land.Dec 23 2017, 5:02 PM
This revision was automatically updated to reflect the committed changes.