databases/kyototycoon: set pidfile before trying to use it
ClosedPublic
Actions

Authored by dch on Dec 21 2017, 11:01 PM.

Details

Reviewers

sunpoet
jrm

Commits

rP462066: databases/kyototycoon: set pidfile before usage

Summary

the current rc.d script uses the pidfile variable before its
defined. This breaks the daemon script.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

dch created this revision.Dec 21 2017, 11:01 PM

Herald added a subscriber: mat. · View Herald TranscriptDec 21 2017, 11:01 PM

Harbormaster completed remote builds in B13733: Diff 36892.Dec 21 2017, 11:01 PM

jrm accepted this revision.Dec 22 2017, 3:34 AM

This revision is now accepted and ready to land.Dec 22 2017, 3:34 AM

I think we need a PORTREVISION bump.

This revision now requires changes to proceed.Dec 22 2017, 3:36 AM

bumping PORTVREVISION will do no harm

Harbormaster completed remote builds in B13741: Diff 36902.Dec 22 2017, 7:39 AM

In D13580#284092, @dch wrote:

bumping PORTVREVISION will do no harm

If the resulting package changes, PORTREVISION needs a bump. You also want users to be running the with the fixed script.

We should wait for sunpoet@ to approve the changes.

LGTM. Thanks!

jrm accepted this revision.Dec 25 2017, 7:14 PM

This revision is now accepted and ready to land.Dec 25 2017, 7:14 PM

Closed by commit rP462066: databases/kyototycoon: set pidfile before usage (authored by dch). · Explain WhyFeb 16 2018, 10:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

databases/

kyototycoon/

Makefile

2 lines

files/

kyototycoon.in

3 lines

Diff 39401

View Options

head/databases/kyototycoon/Makefile