Page MenuHomeFreeBSD

In m_clrprotoflags() cleanup the entire mbuf chain.
ClosedPublic

Authored by glebius on Dec 22 2014, 3:50 PM.
Tags
None
Referenced Files
F149791092: D1352.id2812.diff
Fri, Mar 27, 3:10 AM
Unknown Object (File)
Wed, Mar 25, 9:18 AM
Unknown Object (File)
Wed, Mar 25, 5:54 AM
Unknown Object (File)
Sun, Mar 22, 4:07 AM
Unknown Object (File)
Sat, Mar 21, 10:17 AM
Unknown Object (File)
Sat, Mar 7, 5:45 PM
Unknown Object (File)
Dec 24 2025, 11:43 PM
Unknown Object (File)
Dec 22 2025, 9:15 PM
Subscribers

Details

Summary

The function is designed to cleanup M_PROTO flags when mbufs cross
protocol and facility boundaries. However, now it cleans up only the
first mbuf, while intent clearly means all mbufs in a possible chain.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

glebius retitled this revision from to In m_clrprotoflags() cleanup the entire mbuf chain..
glebius updated this object.
glebius added a reviewer: network.
rpaulo added a reviewer: rpaulo.
rpaulo added a subscriber: rpaulo.

In the commit log, I wouldn't use the pronoun "the" but instead you could make it clear you're talking about m_clrprotoflags().

This revision is now accepted and ready to land.Dec 22 2014, 6:11 PM
gnn added a reviewer: gnn.
gnn added a subscriber: gnn.

Looks good to me.

adrian added a reviewer: adrian.
adrian added a subscriber: adrian.

Yup, looks good to me too.

glebius updated this revision to Diff 2827.

Closed by commit rS276136 (authored by @glebius).