Page MenuHomeFreeBSD
Differential D13459

kern.ipc.{msqids,semsegs,sema} sysctls for FreeBSD32.
ClosedPublic
Actions

Authored by brooks on Dec 12 2017, 2:33 AM.
Tags
None
Referenced Files
Unknown Object (File)
Nov 15 2024, 10:10 AM
Unknown Object (File)
Nov 1 2024, 8:05 PM
Unknown Object (File)
Oct 10 2024, 5:18 PM
Unknown Object (File)
Sep 22 2024, 9:51 PM
Unknown Object (File)
Sep 16 2024, 12:29 PM
Unknown Object (File)
Sep 11 2024, 3:40 PM
Unknown Object (File)
Sep 7 2024, 2:42 PM
Unknown Object (File)
Sep 6 2024, 1:26 AM
View All 47 Files
Subscribers
emaste
gordon
imp
kib

Details

Reviewers
gordon
kib
Group Reviewers
secteam
Commits
rS329177: MFC r328799:
rS328799: Add kern.ipc.{msqids,semsegs,sema} sysctls for FreeBSD32.
Summary

Stop leaking kernel pointers though theses sysctls and make sure that the
padding in the structures is zeroed on allocation to avoid other leaks.

Sponsored by: DARPA, AFRL
Obtained from: CheriBSD

Test Plan

needs testing with 32-bit ipcs or the like on a 64-bit system

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

brooks created this revision.Dec 12 2017, 2:33 AM
brooks added a reviewer: secteam.Dec 12 2017, 2:34 AM

This is technically an information disclosure, but in practice is quite small and unlikely to be a serious issue in the current world order.

emaste added a subscriber: emaste.Dec 12 2017, 1:34 PM
gordon accepted this revision as: gordon.Dec 15 2017, 6:15 AM
gordon added a subscriber: gordon.

Looks okay to me but I'm probably not the best person to judge. If anyone else would like to weigh in. Feel free.

This revision is now accepted and ready to land.Dec 15 2017, 6:15 AM
kib accepted this revision.Jan 30 2018, 5:34 PM
kib added a subscriber: kib.
kib added inline comments.
sys/compat/freebsd32/freebsd32_ipc.h
53 ↗(On Diff #36486)

Wny _kernel32 and not e.g. compat32 ?

sys/kern/sysv_msg.c
232 ↗(On Diff #36486)

Spaces around '|'.

brooks added inline comments.Jan 30 2018, 5:58 PM
sys/compat/freebsd32/freebsd32_ipc.h
53 ↗(On Diff #36486)

Because this is the 32-bit version of struct semid_kernel.

sys/kern/sysv_msg.c
232 ↗(On Diff #36486)

Will fix shortly.

brooks updated this revision to Diff 38681.Jan 30 2018, 5:59 PM
  • style(9)
This revision now requires review to proceed.Jan 30 2018, 5:59 PM
Harbormaster completed remote builds in B14679: Diff 38681.Jan 30 2018, 5:59 PM
brooks marked 4 inline comments as done.Jan 30 2018, 6:00 PM
This revision was not accepted when it landed; it landed in state Needs Review.Feb 2 2018, 6:03 PM
Closed by commit rS328799: Add kern.ipc.{msqids,semsegs,sema} sysctls for FreeBSD32. (authored by brooks). · Explain Why
This revision was automatically updated to reflect the committed changes.
Herald added a subscriber: imp. · View Herald TranscriptFeb 2 2018, 6:03 PM

Revision Contents
Changeset List

PathSize
head/
sys/
compat/
freebsd32/
32 lines
kern/
42 lines
30 lines
37 lines

Diff 38780

View Options

head/sys/compat/freebsd32/freebsd32_ipc.h

Loading...
View Options

head/sys/kern/sysv_msg.c

Loading...
View Options

head/sys/kern/sysv_sem.c

Loading...
View Options

head/sys/kern/sysv_shm.c

Loading...