Deprecated net-p2p/qbittorrent-nox in favor of the flavor in net-p2p/qbittorrent
The previous port was -nox11, not -nox, the flavor should probably be nox11, not nox
If you are using Subversion directly, you need to svn rm the directory for it to show as deleted.
why += ?
Out of order. See Chapter 14. Order of Variables in Port Makefiles.
Why move the DOCS here ? Does the "nox" flavor not have DOCS ?
This was called -nox11 before, it should stay that way.
why := ?
nogui reflects the meaning better. Their option is called --disable-gui. I also suggested to upstream to change suffix to -nogui.
They are developing something called Wayland which is an alternative to Xorg. nogui will cover all GUI cases.
If nogui_LIB_DEPENDS, nogui_PKGNAMESUFFIX and nogui_PLIST are kept here, but the rest with ifs is moved after the USES block, wouldn't this be a violation of Chapter 14. Order of Variables in Port Makefiles? It says that flavors should be before the USES block.
Besides, shouldn't CONFIGURE_ARGS and PLIST_FILES also have corresponding flavor helpers?
I am quite sure this chapter does not say what you are saying. Mostly because I am the one who wrote it.
I know that there are two different paragraphs in 15.7 Flavors but the second paragraph is only one sentence long and is sort of answering exactly what you are asking.