Deprecated net-p2p/qbittorrent-nox in favor of the flavor in net-p2p/qbittorrent
Details
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
No Lint Coverage - Unit
No Test Coverage - Build Status
Buildable 15180 Build 15255: arc lint + arc unit
Event Timeline
arc doesn't support deleted directories, otherwise, net-p2p/qbittorrent-nox is deleted.
The previous port was -nox11, not -nox, the flavor should probably be nox11, not nox
If you are using Subversion directly, you need to svn rm the directory for it to show as deleted.
net-p2p/qbittorrent/Makefile | ||
---|---|---|
36–37 | why += ? | |
38 | Out of order. See Chapter 14. Order of Variables in Port Makefiles. | |
42 | Why move the DOCS here ? Does the "nox" flavor not have DOCS ? | |
46 | This was called -nox11 before, it should stay that way. | |
47 | why := ? | |
net-p2p/qbittorrent/pkg-plist | ||
31 | empty line |
That's what I did, and I added the deleted directory to the command line, and it still doesn't show in phabricator.
nogui reflects the meaning better. Their option is called --disable-gui. I also suggested to upstream to change suffix to -nogui.
They are developing something called Wayland which is an alternative to Xorg. nogui will cover all GUI cases.
net-p2p/qbittorrent/Makefile | ||
---|---|---|
19–34 | I would use the flavor helpers for LIB_DEPENDS, PKGNAMESUFFIX and PLIST and keep them here, and move the rest after the USES block and before options. As Chapter 14. Order of Variables in Port Makefiles says. |
net-p2p/qbittorrent/Makefile | ||
---|---|---|
19–34 | If nogui_LIB_DEPENDS, nogui_PKGNAMESUFFIX and nogui_PLIST are kept here, but the rest with ifs is moved after the USES block, wouldn't this be a violation of Chapter 14. Order of Variables in Port Makefiles? It says that flavors should be before the USES block. Besides, shouldn't CONFIGURE_ARGS and PLIST_FILES also have corresponding flavor helpers? |
net-p2p/qbittorrent/Makefile | ||
---|---|---|
19–34 | I am quite sure this chapter does not say what you are saying. Mostly because I am the one who wrote it. I know that there are two different paragraphs in 15.7 Flavors but the second paragraph is only one sentence long and is sort of answering exactly what you are asking. |
net-p2p/qbittorrent/Makefile | ||
---|---|---|
10 | Qt5 only |
I find it a bit confusing that you chose to have a different flavour name than pkgnamesuffix...
@mat Could you please unblock this? Subversion says that portmgr needs to unblock due to the FLAVORS use.
So do I. I think it would be much better to not have three different strings, nogui, nox11 and nox. Pick one, and use it everywhere.
net-p2p/qbittorrent/Makefile | ||
---|---|---|
39–51 | This should happen earlier. |
Commit still fails:
Committing transaction... svn: E165001: Commit failed (details follow): svn: E165001: Commit blocked by pre-commit hook (exit code 1) with output: Do not commit a port with FLAVORS without first getting approval from portmgr.
You got approval from portmgr. Did you say so in your commit message? If you did not, the script cannot even begin to know it.