Page MenuHomeFreeBSD
Differential D13386

Remove unused 4th argument to match the standard error routines.
ClosedPublic
Actions

Authored by imp on Dec 6 2017, 12:11 AM.
Tags
None
Referenced Files
F82019521: D13386.diff
Wed, Apr 24, 3:38 PM
Unknown Object (File)
Jan 18 2024, 1:13 PM
Unknown Object (File)
Jan 5 2024, 5:38 PM
Unknown Object (File)
Dec 3 2023, 10:00 AM
Unknown Object (File)
Aug 26 2023, 12:53 PM
Unknown Object (File)
Aug 8 2023, 2:02 AM
Unknown Object (File)
Aug 8 2023, 2:01 AM
Unknown Object (File)
Aug 8 2023, 1:56 AM
View All 13 Files
Subscribers
None

Details

Reviewers
scottl
ken
cem
Commits
rS326606: Remove unused 4th argument to match the standard error routines.
Summary

This argument isn't used, and didn't match the usual error routines, so remove it. It serves no purpose.

Diff Detail

Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 13366
Build 13598: arc lint + arc unit

Event Timeline

imp created this revision.Dec 6 2017, 12:11 AM
Harbormaster completed remote builds in B13366: Diff 36275.Dec 6 2017, 12:11 AM
imp edited the summary of this revision. (Show Details)Dec 6 2017, 12:12 AM
imp added reviewers: scottl, ken, cem.
cem accepted this revision.Dec 6 2017, 12:15 AM
cem added inline comments.
sys/cam/cam_periph.c
1715

Was this formerly used somehow?

This revision is now accepted and ready to land.Dec 6 2017, 12:15 AM
imp added inline comments.Dec 6 2017, 12:21 AM
sys/cam/cam_periph.c
1715

It was, but I haven't done a the full archeological dig to find out what it was...

Closed by commit rS326606: Remove unused 4th argument to match the standard error routines. (authored by imp). · Explain WhyDec 11 2017, 5:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
sys/
cam/
ata/
2 lines
2 lines
4 lines
2 lines
4 lines
mmc/
2 lines
nvme/
6 lines
scsi/
3 lines
3 lines
7 lines
2 lines
3 lines
3 lines
4 lines
3 lines

Diff 36275

View Options

sys/cam/ata/ata_da.c

Loading...
View Options

sys/cam/ata/ata_pmp.c

Loading...
View Options

sys/cam/ata/ata_xpt.c

Loading...
View Options

sys/cam/cam_periph.h

Loading...
View Options

sys/cam/cam_periph.c

Loading...
View Options

sys/cam/mmc/mmc_da.c

Loading...
View Options

sys/cam/nvme/nvme_da.c

Loading...
View Options

sys/cam/scsi/scsi_cd.c

Loading...
View Options

sys/cam/scsi/scsi_ch.c

Loading...
View Options

sys/cam/scsi/scsi_da.c

Loading...
View Options

sys/cam/scsi/scsi_enc.c

Loading...
View Options

sys/cam/scsi/scsi_pass.c

Loading...
View Options

sys/cam/scsi/scsi_pt.c

Loading...
View Options

sys/cam/scsi/scsi_sa.c

Loading...
View Options

sys/cam/scsi/scsi_sg.c

Loading...