Page MenuHomeFreeBSD
Differential D13386

Remove unused 4th argument to match the standard error routines.
ClosedPublic
Actions

Authored by imp on Dec 6 2017, 12:11 AM.
Tags
None
Referenced Files
F169251719: D13386.id.diff
Tue, Sep 1, 1:42 AM
F169206371: D13386.diff
Mon, Aug 31, 8:12 PM
F169064773: D13386.id36436.diff
Mon, Aug 31, 7:35 AM
Unknown Object (File)
Sun, Aug 30, 1:06 AM
Unknown Object (File)
Sat, Aug 29, 4:52 PM
Unknown Object (File)
Sat, Aug 29, 10:58 AM
Unknown Object (File)
Thu, Aug 27, 7:20 PM
Unknown Object (File)
Thu, Aug 27, 4:10 PM
View All Files
Subscribers
None

Details

Reviewers
scottl
ken
cem
Commits
rS326606: Remove unused 4th argument to match the standard error routines.
Summary

This argument isn't used, and didn't match the usual error routines, so remove it. It serves no purpose.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

imp created this revision.Dec 6 2017, 12:11 AM
Harbormaster completed remote builds in B13366: Diff 36275.Dec 6 2017, 12:11 AM
imp edited the summary of this revision. (Show Details)Dec 6 2017, 12:12 AM
imp added reviewers: scottl, ken, cem.
cem accepted this revision.Dec 6 2017, 12:15 AM
cem added inline comments.
sys/cam/cam_periph.c
1715 ↗(On Diff #36275)

Was this formerly used somehow?

This revision is now accepted and ready to land.Dec 6 2017, 12:15 AM
imp added inline comments.Dec 6 2017, 12:21 AM
sys/cam/cam_periph.c
1715 ↗(On Diff #36275)

It was, but I haven't done a the full archeological dig to find out what it was...

Closed by commit rS326606: Remove unused 4th argument to match the standard error routines. (authored by imp). · Explain WhyDec 11 2017, 5:15 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
sys/
cam/
ata/
2 lines
2 lines
4 lines
2 lines
4 lines
mmc/
2 lines
nvme/
6 lines
scsi/
3 lines
3 lines
7 lines
2 lines
3 lines
3 lines
4 lines
3 lines
34 lines

Diff 36436

View Options

head/sys/cam/ata/ata_da.c

Loading...
View Options

head/sys/cam/ata/ata_pmp.c

Loading...
View Options

head/sys/cam/ata/ata_xpt.c

Loading...
View Options

head/sys/cam/cam_periph.h

Loading...
View Options

head/sys/cam/cam_periph.c

Loading...
View Options

head/sys/cam/mmc/mmc_da.c

Loading...
View Options

head/sys/cam/nvme/nvme_da.c

Loading...
View Options

head/sys/cam/scsi/scsi_cd.c

Loading...
View Options

head/sys/cam/scsi/scsi_ch.c

Loading...
View Options

head/sys/cam/scsi/scsi_da.c

Loading...
View Options

head/sys/cam/scsi/scsi_enc.c

Loading...
View Options

head/sys/cam/scsi/scsi_pass.c

Loading...
View Options

head/sys/cam/scsi/scsi_pt.c

Loading...
View Options

head/sys/cam/scsi/scsi_sa.c

Loading...
View Options

head/sys/cam/scsi/scsi_sg.c

Loading...
View Options

head/sys/cam/scsi/scsi_xpt.c

Loading...