Add new port sysutils/circonus-agent

[sam_samgwydir.com]

Test Plan

Built using poudriere testport, installed and run a minimal config

[tobik]

Does it pass poudriere testport?

sysutils/circonus-agent/Makefile

1

Missing # $FreeBSD$ at the top.

2

Use DISTVERSION

9

Add LICENSE_FILE if possible.

19

Typo?

22–23

Not sure why this is necessary, but please use ${MKDIR} and ${MV}.

sysutils/circonus-agent/pkg-descr

1

Too short.

[sam_samgwydir.com]

sysutils/circonus-agent/Makefile

19

No, following the instructions at the bottom of https://github.com/circonus-labs/circonus-agent, users might expect this name.

22–23

dep wants the build directory in the standard Go layout and on top of that, doesn't want to see the same source twice, so I moved the contents to where a symlink is usually constructed by post-extract in the go uses file.

[sam_samgwydir.com]

Updated pkg-descr.

[mat]

sysutils/circonus-agent/Makefile

17

I wonder what good is USES=go if you overwrite all the targets it uses. If it is to get the dependency on go, better add it yourself rather than depending on USES=go to do it.

[sam_samgwydir.com]

Updated to remove dep dependency and now works when built in poudriere.

[sam_samgwydir.com]

circonus-agent doesn't specify what version of go it needs to build, changing go>=1.8 to just a dependency on go.

[sam_samgwydir.com]

Passes portlint -Aac, builds in {10.4, 11.1, CURRENT}-{i386,amd64} with poudriere testport.

[mat]

sysutils/circonus-agent/Makefile

19

default, remove.

54

GH_SUBDIR= /src/github.com/circonus-labs/circonus-agent

sysutils/circonus-agent/pkg-plist

2 ↗

(On Diff #36745)

This is bogus, %%ETCDIR%% is supposed to be a directory, not part of a path, so you should set ETCDIR=${PREFIX}/etc/circonus-agentd in the Makefile.

[swills]

sysutils/circonus-agent/pkg-plist

2 ↗

(On Diff #36745)

Also, might be better to use PLIST_FILES since the plist is so short.