Built using poudriere testport, installed and run a minimal config
Details
Details
- Reviewers
- None
- Commits
- rP459193: new port sysutils/circonus-agent: agent for metric collection integrating with…
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Does it pass poudriere testport?
| sysutils/circonus-agent/Makefile | ||
|---|---|---|
| 1 ↗ | (On Diff #36199) | Missing # $FreeBSD$ at the top. |
| 2 ↗ | (On Diff #36199) | Use DISTVERSION |
| 9 ↗ | (On Diff #36199) | Add LICENSE_FILE if possible. |
| 19 ↗ | (On Diff #36199) | Typo? |
| 22–23 ↗ | (On Diff #36199) | Not sure why this is necessary, but please use ${MKDIR} and ${MV}. |
| sysutils/circonus-agent/pkg-descr | ||
| 1 ↗ | (On Diff #36199) | Too short. |
| sysutils/circonus-agent/Makefile | ||
|---|---|---|
| 19 ↗ | (On Diff #36199) | No, following the instructions at the bottom of https://github.com/circonus-labs/circonus-agent, users might expect this name. |
| 22–23 ↗ | (On Diff #36199) | dep wants the build directory in the standard Go layout and on top of that, doesn't want to see the same source twice, so I moved the contents to where a symlink is usually constructed by post-extract in the go uses file. |
| sysutils/circonus-agent/Makefile | ||
|---|---|---|
| 16 ↗ | (On Diff #36211) | I wonder what good is USES=go if you overwrite all the targets it uses. If it is to get the dependency on go, better add it yourself rather than depending on USES=go to do it. |
Comment Actions
circonus-agent doesn't specify what version of go it needs to build, changing go>=1.8 to just a dependency on go.
Comment Actions
Passes portlint -Aac, builds in {10.4, 11.1, CURRENT}-{i386,amd64} with poudriere testport.
| sysutils/circonus-agent/Makefile | ||
|---|---|---|
| 18 ↗ | (On Diff #36745) | default, remove. |
| 53 ↗ | (On Diff #36745) | GH_SUBDIR= /src/github.com/circonus-labs/circonus-agent |
| sysutils/circonus-agent/pkg-plist | ||
| 2 ↗ | (On Diff #36745) | This is bogus, %%ETCDIR%% is supposed to be a directory, not part of a path, so you should set ETCDIR=${PREFIX}/etc/circonus-agentd in the Makefile. |
| sysutils/circonus-agent/pkg-plist | ||
|---|---|---|
| 2 ↗ | (On Diff #36745) | Also, might be better to use PLIST_FILES since the plist is so short. |