Go dependency management tool
Details
Details
- Reviewers
- None
- Commits
- rP458984: devel/dep: create port
Installed a used as a dependency for sysutils/circonus-agent.
Diff Detail
Diff Detail
- Repository
- rP FreeBSD ports repository
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Does it pass poudriere testport?
| devel/dep/Makefile | ||
|---|---|---|
| 1 ↗ | (On Diff #36198) | You're missing # $FreeBSD$ at the top. |
| 2 ↗ | (On Diff #36198) | Use DISTVERSION |
| 7 ↗ | (On Diff #36198) | This cannot have passed portlint. Remove dep is a, the dot at the end, and capitalize prototype. |
| 9 ↗ | (On Diff #36198) | Missing LICENSE_FILE |
| 11 ↗ | (On Diff #36198) | Why? You USES=go which adds it already. |
| devel/dep/pkg-descr | ||
| 1 ↗ | (On Diff #36198) | Please make it at least a paragraph or two. It should be more than just a repetition of COMMENT. |
| devel/dep/Makefile | ||
|---|---|---|
| 7 ↗ | (On Diff #36198) | Agreed on everything else but capitalize prototype? |
| devel/dep/Makefile | ||
|---|---|---|
| 7 ↗ | (On Diff #36198) | Yes, COMMENTs always start with a captial letter. https://www.freebsd.org/doc/en/books/porters-handbook/makefile-comment.html COMMENT= Prototype dependency management tool for Go |
Comment Actions
Completed your requests -- lengthened pkg-descr but I have someone writing a better one up for me. That should be here soon.