Add new port devel/dep
ClosedPublic

Authored by sam_samgwydir.com on Dec 4 2017, 6:45 PM.

Details

Reviewers
None
Commits
rP458984: devel/dep: create port
Summary

Go dependency management tool

https://github.com/golang/dep

Test Plan

Installed a used as a dependency for sysutils/circonus-agent.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.
tobik added a subscriber: tobik.Dec 4 2017, 7:04 PM

Does it pass poudriere testport?

devel/dep/Makefile
1 ↗(On Diff #36198)

You're missing # $FreeBSD$ at the top.

2 ↗(On Diff #36198)

Use DISTVERSION

7 ↗(On Diff #36198)

This cannot have passed portlint. Remove dep is a, the dot at the end, and capitalize prototype.

9 ↗(On Diff #36198)

Missing LICENSE_FILE

11 ↗(On Diff #36198)

Why? You USES=go which adds it already.

devel/dep/pkg-descr
1 ↗(On Diff #36198)

Please make it at least a paragraph or two. It should be more than just a repetition of COMMENT.

devel/dep/Makefile
7 ↗(On Diff #36198)

Agreed on everything else but capitalize prototype?

tobik added inline comments.Dec 4 2017, 7:49 PM
devel/dep/Makefile
7 ↗(On Diff #36198)

Yes, COMMENTs always start with a captial letter.

https://www.freebsd.org/doc/en/books/porters-handbook/makefile-comment.html

COMMENT=        Prototype dependency management tool for Go
sam_samgwydir.com marked 8 inline comments as done.
sam_samgwydir.com marked an inline comment as not done.

Completed your requests -- lengthened pkg-descr but I have someone writing a better one up for me. That should be here soon.

Updated pkg-descr

sam_samgwydir.com marked an inline comment as done.Dec 5 2017, 7:24 PM

This passes poudriere testport.

This revision was not accepted when it landed; it landed in state Needs Review.Sun, Jan 14, 5:25 PM
Closed by commit rP458984: devel/dep: create port (authored by swills, committed by ). · Explain Why
This revision was automatically updated to reflect the committed changes.