Page MenuHomeFreeBSD
Differential D13345

irc/inspircd: Modernize port
ClosedPublic
Actions

Authored by yuri on Dec 2 2017, 8:23 PM.
Tags
None
Referenced Files
Unknown Object (File)
Fri, Apr 25, 8:25 PM
Unknown Object (File)
Sun, Apr 20, 7:59 PM
Unknown Object (File)
Sun, Apr 20, 7:09 PM
Unknown Object (File)
Sat, Apr 19, 6:19 PM
Unknown Object (File)
Sat, Apr 19, 2:45 PM
Unknown Object (File)
Thu, Apr 17, 12:44 AM
Unknown Object (File)
Wed, Apr 16, 8:49 PM
Unknown Object (File)
Wed, Apr 16, 8:47 PM
View All 83 Files
Subscribers
lwhsu
mat
Contributor Reviewers (ports)

Details

Reviewers
tcberner
adamw
dmgk
Commits
rP456702: irc/inspircd: Modernize port (adding files/pkg-deinstall.in)
rP456675: irc/inspircd: Modernize port
Summary

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=224041

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

dmgk created this revision.Dec 2 2017, 8:23 PM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald TranscriptDec 2 2017, 8:23 PM
Harbormaster completed remote builds in B13283: Diff 36118.Dec 2 2017, 8:23 PM
lwhsu added a subscriber: lwhsu.Dec 4 2017, 3:52 AM
lwhsu added inline comments.
irc/inspircd/Makefile
1 ↗(On Diff #36118)

Have you got explicitly approval from the original creator?

dmgk added inline comments.Dec 4 2017, 4:40 AM
irc/inspircd/Makefile
1 ↗(On Diff #36118)

No, but Created By are obsolete. Do you want me to put it back?

mat added inline comments.Dec 4 2017, 1:30 PM
irc/inspircd/Makefile
5 ↗(On Diff #36118)

The version did not change, please do not change this.

dmgk updated this revision to Diff 36187.Dec 4 2017, 1:51 PM
  • Put back Created By
  • Revert to PORTVERSION
Harbormaster completed remote builds in B13322: Diff 36187.Dec 4 2017, 1:51 PM
dmgk marked 2 inline comments as done.Dec 4 2017, 1:52 PM
yuri commandeered this revision.Dec 18 2017, 6:38 PM
yuri added reviewers: tcberner, adamw.
yuri added a reviewer: dmgk.
adamw accepted this revision.Dec 18 2017, 9:36 PM

Looks good! I'm not build-testing these by the way, Yuri. I trust you for it.

This revision is now accepted and ready to land.Dec 18 2017, 9:36 PM
Closed by commit rP456675: irc/inspircd: Modernize port (authored by yuri). · Explain WhyDec 18 2017, 9:47 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
head/
irc/
inspircd/
180 lines
files/
31 lines
422 lines

Diff 36725

View Options

head/irc/inspircd/Makefile

Loading...
View Options

head/irc/inspircd/files/inspircd.in

Loading...
View Options

head/irc/inspircd/pkg-plist

Loading...