Page MenuHomeFreeBSD
Differential D13311

Make COMPAT_FREEBSD32 part of GENERIC on arm64.
ClosedPublic
Actions

Authored by ed on Nov 30 2017, 6:18 PM.
Tags
None
Referenced Files
Unknown Object (File)
Wed, Jan 8, 11:57 PM
Unknown Object (File)
Mon, Jan 6, 11:29 AM
Unknown Object (File)
Sat, Jan 4, 12:34 PM
Unknown Object (File)
Dec 13 2024, 1:57 AM
Unknown Object (File)
Dec 13 2024, 12:52 AM
Unknown Object (File)
Dec 4 2024, 5:07 AM
Unknown Object (File)
Dec 4 2024, 5:07 AM
Unknown Object (File)
Dec 4 2024, 5:07 AM
View All 56 Files
Subscribers
emaste
imp

Details

Reviewers
andrew
imp
Commits
rS326501: Make COMPAT_FREEBSD32 part of GENERIC on arm64.
Summary

The cloudabi32.ko kernel modules can only be loaded on AMD64 and ARM64
by kernels built with COMPAT_FREEBSD32. Even though COMPAT_FREEBSD32
does not support the execution of native FreeBSD executables, do add it
to GENERIC, to make cloudabi32.ko usable.

According to size(1), this makes the kernel image approximately 0.7%
larger.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

ed created this revision.Nov 30 2017, 6:18 PM
Herald added subscribers: emaste, imp. · View Herald TranscriptNov 30 2017, 6:18 PM
Harbormaster completed remote builds in B13204: Diff 36016.Nov 30 2017, 6:18 PM
imp accepted this revision.Nov 30 2017, 6:40 PM

Well, if it was 0.8% larger, I'd have my pitch-pots and feather bags lined up, but for only 0.7%, I'm good.

This revision is now accepted and ready to land.Nov 30 2017, 6:40 PM
andrew added inline comments.Nov 30 2017, 7:15 PM
sys/arm64/conf/GENERIC
55 ↗(On Diff #36016)

Should there be a comment that this only works with CloudABI?

ed updated this revision to Diff 36035.Dec 1 2017, 5:55 AM

Use a different description that fits within 80 columns.

This revision now requires review to proceed.Dec 1 2017, 5:55 AM
ed added inline comments.Dec 1 2017, 5:55 AM
sys/arm64/conf/GENERIC
55 ↗(On Diff #36016)

Sure. What do you think about this description?

emaste added a comment.Dec 1 2017, 7:14 PM

Description looks good.

Question, what happens on hardware w/o AArch32?

andrew added a comment.Dec 3 2017, 10:17 AM
In D13311#278098, @emaste wrote:

Description looks good.

Question, what happens on hardware w/o AArch32?

You'll probably get an exception on the first instruction.

A simple way would be to set a flag in identcpu.c under the ID_AA64PFR0_EL0 case to signal no 32-bit support if any CPUs lack it. This could then be queried in the exec path & complain to the user if it's unable to be run. We can test on ThunderX as it only supports AArch64.

Closed by commit rS326501: Make COMPAT_FREEBSD32 part of GENERIC on arm64. (authored by ed). · Explain WhyDec 3 2017, 7:26 PM
This revision was automatically updated to reflect the committed changes.
ed added a comment.Dec 3 2017, 7:30 PM

Hi Andrew,

In D13311#278604, @andrew wrote:

Question, what happens on hardware w/o AArch32?

You'll probably get an exception on the first instruction.

A simple way would be to set a flag in identcpu.c under the ID_AA64PFR0_EL0 case to signal no 32-bit support if any CPUs lack it. This could then be queried in the exec path & complain to the user if it's unable to be run. We can test on ThunderX as it only supports AArch64.

Good point. The existing cloudabi32.ko doesn't do anything with that at all. Would it make sense to let the modload fail in case the CPU doesn't support it?

Revision Contents
Changeset List

PathSize
head/
sys/
arm64/
conf/
1 line

Diff 36158

View Options

head/sys/arm64/conf/GENERIC

Loading...