Page MenuHomeFreeBSD
Differential D13246

New stage-qa check: emptydirs: Warn when there are empty directories in DOCSDIR, EXAMPLESDIR
AbandonedPublic
Actions

Authored by yuri on Nov 26 2017, 9:12 AM.
Tags
None
Referenced Files
Unknown Object (File)
May 9 2024, 2:38 AM
Unknown Object (File)
May 9 2024, 2:37 AM
Unknown Object (File)
May 8 2024, 6:15 PM
Unknown Object (File)
Jan 30 2024, 7:53 PM
Unknown Object (File)
Dec 22 2023, 4:12 AM
Unknown Object (File)
Dec 20 2023, 5:33 AM
Unknown Object (File)
Dec 10 2023, 2:23 AM
Unknown Object (File)
Aug 25 2023, 2:09 AM
View All 10 Files
Subscribers
mat
Contributor Reviewers (ports)

Details

Reviewers
antoine
tcberner
adamw
Group Reviewers
O5: Ports Framework(Owns No Changed Paths)
portmgr
Summary

Such directories are useless.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 13069
Build 13319: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 26 2017, 9:12 AM
Owners added a reviewer: O5: Ports Framework.Nov 26 2017, 9:12 AM
Herald added a reviewer: portmgr. · View Herald TranscriptNov 26 2017, 9:12 AM
Herald added subscribers: Contributor Reviewers (ports), mat. · View Herald Transcript
Harbormaster completed remote builds in B13069: Diff 35794.Nov 26 2017, 9:12 AM
yuri retitled this revision from New stage-qa phase: emptydirs: Warn when there are empty directories in DOCSDIR, EXAMPLESDIR to New stage-qa check: emptydirs: Warn when there are empty directories in DOCSDIR, EXAMPLESDIR.Nov 26 2017, 9:12 AM
yuri added a reviewer: antoine.
yuri added reviewers: tcberner, adamw.
mat added a comment.Nov 27 2017, 1:39 PM

I disagree, they may be useless in the specific case you looked at, but they may be required in some cases.

In any way, make makeplist will show empty directories as %%PORTDOCS%%@dir %%DOCSDIR%%/foo and the porter will know they have to remove them.

yuri abandoned this revision.Nov 27 2017, 5:55 PM

Revision Contents
Changeset List

PathSize
Mk/
Scripts/
19 lines
2 lines

Diff 35794

View Options

Mk/Scripts/qa.sh

Loading...
View Options

Mk/bsd.port.mk

Loading...