databases/sqlitestudio: Unbroke the build by including QVariant where it was missing
ClosedPublic
Actions

Authored by yuri on Nov 23 2017, 2:10 AM.

Details

Reviewers

tcberner
adamw
mat

Commits

rP454970: databases/sqlitestudio: Unbroke the build by including QVariant where it was…

Summary

Simple update.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

No Lint Coverage

Unit

No Test Coverage

Build Status

Buildable 12964
Build 13222: arc lint + arc unit

Event Timeline

yuri created this revision.Nov 23 2017, 2:10 AM

Herald added a subscriber: mat. · View Herald TranscriptNov 23 2017, 2:10 AM

Harbormaster completed remote builds in B12959: Diff 35626.Nov 23 2017, 2:10 AM

tcberner added inline comments.Nov 23 2017, 5:41 AM

databases/sqlitestudio/Makefile
5–6	^Why change this, it also requires the DISTNAME, and the port ist named sqlitebrowser :)

yuri marked an inline comment as done.Nov 23 2017, 5:43 AM

yuri added inline comments.

databases/sqlitestudio/Makefile
5–6	They call it SQLiteStudio here: https://sqlitestudio.pl

tcberner added inline comments.Nov 23 2017, 6:00 AM

databases/sqlitestudio/Makefile
5–6	I don't think that is worth the change -- if the distfile were called that too, yes.

Restored the package name.

yuri retitled this revision from databases/sqlitestudio: Unbroke the build; Changed the package name to mixed case to reflect how it calls itself to databases/sqlitestudio: Unbroke the build by including QVariant where it was missing.Nov 23 2017, 6:16 AM

yuri marked 2 inline comments as done.Nov 24 2017, 7:19 AM

mat requested changes to this revision.Nov 24 2017, 6:30 PM

mat added inline comments.