Page MenuHomeFreeBSD

databases/sqlitestudio: Unbroke the build by including QVariant where it was missing
ClosedPublic

Authored by yuri on Nov 23 2017, 2:10 AM.
Tags
None
Referenced Files
F81747130: D13203.diff
Sat, Apr 20, 7:11 PM
Unknown Object (File)
Fri, Apr 19, 1:33 PM
Unknown Object (File)
Fri, Apr 5, 6:06 PM
Unknown Object (File)
Tue, Apr 2, 10:36 PM
Unknown Object (File)
Mar 4 2024, 3:31 PM
Unknown Object (File)
Mar 4 2024, 3:31 PM
Unknown Object (File)
Mar 4 2024, 3:31 PM
Unknown Object (File)
Mar 4 2024, 3:31 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12959
Build 13217: arc lint + arc unit

Event Timeline

databases/sqlitestudio/Makefile
4

^Why change this, it also requires the DISTNAME, and the port ist named sqlitebrowser :)

yuri marked an inline comment as done.Nov 23 2017, 5:43 AM
yuri added inline comments.
databases/sqlitestudio/Makefile
4

They call it SQLiteStudio here: https://sqlitestudio.pl

databases/sqlitestudio/Makefile
4

I don't think that is worth the change -- if the distfile were called that too, yes.

yuri marked an inline comment as done.

Restored the package name.

yuri retitled this revision from databases/sqlitestudio: Unbroke the build; Changed the package name to mixed case to reflect how it calls itself to databases/sqlitestudio: Unbroke the build by including QVariant where it was missing.Nov 23 2017, 6:16 AM
yuri marked 2 inline comments as done.Nov 24 2017, 7:19 AM
mat requested changes to this revision.Nov 24 2017, 6:30 PM
mat added inline comments.
databases/sqlitestudio/Makefile
4–6

Do not change PORTVERSION if the version does not change.

This revision now requires changes to proceed.Nov 24 2017, 6:30 PM

Brought back PORTVERSION.

yuri marked an inline comment as done.Nov 24 2017, 9:02 PM

@mat

PORTVERSION has been changed back. Is there anything else? Otherwise, could you please approve it?

Thanks!

This revision is now accepted and ready to land.Nov 27 2017, 1:44 PM
This revision was automatically updated to reflect the committed changes.