Page MenuHomeFreeBSD

textproc/fcitx-qt5: Update to 1.2.1
ClosedPublic

Authored by yuri on Nov 22 2017, 11:31 PM.

Details

Summary

Simple update.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

textproc/fcitx-qt5/Makefile
20 ↗(On Diff #35624)

^ qmake_build should suffice

yuri marked an inline comment as done.Nov 23 2017, 5:51 AM
yuri added inline comments.
textproc/fcitx-qt5/Makefile
20 ↗(On Diff #35624)

Indeed. -)

yuri marked 2 inline comments as done.Nov 23 2017, 5:51 AM
textproc/fcitx-qt5/Makefile
16 ↗(On Diff #35631)

^ drop gettext

23 ↗(On Diff #35631)

^ NLS_USES=gettext

23 ↗(On Diff #35631)

^ not here, but near NLS_CMAKE_BOOL ^^

yuri marked 3 inline comments as done.

.

textproc/fcitx-qt5/Makefile
16 ↗(On Diff #35631)

cmake's NLS doesn't cleanly disable gettext. I added it with a patch, but it was incomplete. I rolled it back, and asked them to implement it: https://github.com/fcitx/fcitx-qt5/issues/29

yuri marked an inline comment as done.Nov 23 2017, 6:12 AM
This revision is now accepted and ready to land.Nov 23 2017, 6:31 AM
This revision was automatically updated to reflect the committed changes.