Return different error code for the guard page layout violation.
ClosedPublic
Actions

Authored by kib on Nov 21 2017, 10:01 PM.

Details

Reviewers

alc
markj
jhb

Commits

rS326098: Return different error code for the guard page layout violation.

Diff Detail

Repository

rS FreeBSD src repository - subversion

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

kib created this revision.Nov 21 2017, 10:01 PM

Herald added a subscriber: imp. · View Herald TranscriptNov 21 2017, 10:01 PM

kib mentioned this in D13155: Do not loop infinitely in vm_map_find()..Nov 21 2017, 10:06 PM

alc added inline comments.Nov 22 2017, 8:50 AM

sys/vm/vm_map.c
3619–3621 ↗	(On Diff #35568)	vm_map_insert() returns KERN_INVALID_ARGUMENT for all of these errors. I would argue that this function should do the same, both for consistency with vm_map_insert() and because KERN_INVALID_ARGUMENT better describes these errors. Also, vm_map_insert() has a slighyly different "max" check. The equivalent would be "addrbos + max_ssize > vm_map_max(map)".

alc added inline comments.Nov 22 2017, 8:59 AM

sys/vm/vm_map.c
3619–3621 ↗	(On Diff #35568)	vm_map_insert()'s address wrap check also uses <= rather than <.

Duplicate the vm_map_insert() behavior for error checking WRT the address range checking.

I've skimmed the code for both this function and vm_map_insert(), and I believe that both the error checks and their corresponding return values are now consistent.

This revision is now accepted and ready to land.Nov 22 2017, 4:19 PM

markj accepted this revision.Nov 22 2017, 4:26 PM

Closed by commit rS326098: Return different error code for the guard page layout violation. (authored by kib). · Explain WhyNov 22 2017, 4:45 PM

This revision was automatically updated to reflect the committed changes.