New port: audio/carla: Audio LV2 plugin host for Jack and PulseAudio

[yuri]

Summary

I would like to thank the Carla developer, Filipe Coelho (falkTX), for his great help in polishing this port and making it ready for the FreeBSD!

[yuri]

.

[yuri]

.

[yuri]

.

[yuri]

Updated according to falkTX requests.

[yuri]

.

[yuri]

.

[yuri]

.

[yuri]

.

[yuri]

.

[yuri]

Updated.

[yuri]

Update.

[yuri]

The final version.

[mat]

audio/carla/Makefile

38

Why +=?

[yuri]

audio/carla/Makefile

38

It's nicer to group the audio backend options. OPTIONS_MULTI_BACKEND=JACK PULSEAUDIO is defined below the main options.

[yuri]

.

[tcberner]

audio/carla/Makefile

18

^ seems a bit on the long side here, maybe break around pkgconfig

21

'^ I would group these by _run resp _build. So

USE_PYQT= core_run gui_run svg_run widgets_run \
          sip_build xml_build

45

why not JACK_LIB_DEPENDS=libjack.so:audio/jack?

[tcberner]

audio/carla/Makefile

33

^ OPTIONS_MULTI= has spaces

35

^OPTIONS_MULTI_BACKEND has spaces

[yuri]

audio/carla/Makefile

45

It's a run dependency.

[yuri]

.

[yuri]

.

[tcberner]

I think you lost some files in the last change [pkg-descr, distinfo]

[yuri]

Some files were missing

[tcberner]

It fails for me in the dependency audio/py-pyliblo.

[yuri]

In D13172#276052, @tcberner wrote:

It fails for me in the dependency audio/py-pyliblo.

audio/py-pyliblo: https://reviews.freebsd.org/D13189

[tcberner]

right, you should commit that one then :)

[yuri]

In D13172#276069, @tcberner wrote:

right, you should commit that one then :)

I just did. Sorry, I was out for a while. :)

[tcberner]

===>   Carla-1.9.7.b.279 depends on shared library: liblinuxsampler.so - not found

===========================================================================
====>> Checking for filesystem violations... done
====>> Error: Filesystem touched during build:
extra: usr/local/lib/python3.6/site-packages/PyQt5/__pycache__/pyrcc_main.cpython-36.pyc

[yuri]

In D13172#276073, @tcberner wrote:

===>   Carla-1.9.7.b.279 depends on shared library: liblinuxsampler.so - not found

===========================================================================
====>> Checking for filesystem violations... done
====>> Error: Filesystem touched during build:
extra: usr/local/lib/python3.6/site-packages/PyQt5/__pycache__/pyrcc_main.cpython-36.pyc

There's the line LINUXSAMPLER_LIB_DEPENDS=liblinuxsampler.so:audio/linuxsampler, and audio/linuxsampler is committed, so it should be found.
Are you sure you've updated your jail?

[tcberner]

In D13172#276081, @yuri wrote:

In D13172#276073, @tcberner wrote:

===>   Carla-1.9.7.b.279 depends on shared library: liblinuxsampler.so - not found

===========================================================================
====>> Checking for filesystem violations... done
====>> Error: Filesystem touched during build:
extra: usr/local/lib/python3.6/site-packages/PyQt5/__pycache__/pyrcc_main.cpython-36.pyc

There's the line LINUXSAMPLER_LIB_DEPENDS=liblinuxsampler.so:audio/linuxsampler, and audio/linuxsampler is committed, so it should be found.
Are you sure you've updated your jail?

yes, the lib depends is there, -- the second time around it found it, but it failed stage-qa, which you still should look into :)

[yuri]

In D13172#276082, @tcberner wrote:

yes, the lib depends is there, -- the second time around it found it, but it failed stage-qa, which you still should look into :)

Hm, stage-qa succeeds here.

[yuri]

I've just rebuilt both, and they both succeed:

[00:05:24] [01] [00:05:16] Finished audio/linuxsampler | linuxsampler-2.0.0: Success
[00:05:24] [01] [00:00:00] Building audio/carla | Carla-1.9.7.b.279
[00:08:12] [01] [00:02:48] Finished audio/carla | Carla-1.9.7.b.279: Success

[tcberner]

[00:02:04] ====>> Failed ports: audio/carla:build_fs_violation

freshly updated ports tree :)

[yuri]

In D13172#276108, @tcberner wrote:

[00:02:04] ====>> Failed ports: audio/carla:build_fs_violation

freshly updated ports tree :)

I also updated the ports tree, and it succeeded in both jails: 11.0-RELEASE-p2 amd64 and 10.3-RELEASE-p21 i386.
What system does it fail on, and what is the audio/carla:build_fs_violation file?

[tcberner]

In D13172#276142, @yuri wrote:

In D13172#276108, @tcberner wrote:

[00:02:04] ====>> Failed ports: audio/carla:build_fs_violation

freshly updated ports tree :)

I also updated the ports tree, and it succeeded in both jails: 11.0-RELEASE-p2 amd64 and 10.3-RELEASE-p21 i386.
What system does it fail on, and what is the audio/carla:build_fs_violation file?

The fs-violation is the following error:

===========================================================================
====>> Checking for filesystem violations... done
====>> Error: Filesystem touched during build:
extra: usr/local/lib/python3.6/site-packages/PyQt5/__pycache__/pyrcc_main.cpython-36.pyc

[yuri]

In D13172#276187, @tcberner wrote:

The fs-violation is the following error:

===========================================================================
====>> Checking for filesystem violations... done
====>> Error: Filesystem touched during build:
extra: usr/local/lib/python3.6/site-packages/PyQt5/__pycache__/pyrcc_main.cpython-36.pyc

I can't reproduce it. :(
On its face it looks like a python bug, because __pycache__ is for python cache.
Should I create the bug report? But I can't reproduce it myself ...

[yuri]

Here's how Carla actually looks on FreeBSD: https://user-images.githubusercontent.com/271906/33252204-88602bc0-d2f1-11e7-8fa7-f4526e8dcb49.png
:)

[mat]

audio/carla/Makefile

38

Well, the variables are out of order anyway.

[yuri]

.

[yuri]

@tcberner Tobias, if the fs error is reproducible, it should be reported to the python team.
In the meantime, if the failure is only on 12 as I suspect it is (I don't see the failure on 10 and 11.1), it should probably be committed because there's nothing obviously wrong with it python-wise.

[tcberner]

I have it on 10 and 12 :) -- I assume you are trying it with bulk -t?

But yeah, it probably should not block this .)

audio/carla/Makefile

25

^ move USE_GNOME above USE_PYQT (so it's at least somewhat alphabetically sorted USE_GNOME, USE_PYQT, USE_QT)

[yuri]

In D13172#277447, @tcberner wrote:

I have it on 10 and 12 :) -- I assume you are trying it with bulk -t?

But yeah, it probably should not block this .)

I run the command:
poudriere bulk -j $J -p local -z workstation -t $*

[yuri]

order

[tcberner]

My only real nitpick is the PKGBASE 'Carla' vs directory audio/carla.

[yuri]

In D13172#277470, @tcberner wrote:

My only real nitpick is the PKGBASE 'Carla' vs directory audio/carla.

This is the case of standard capitalization, not like non-standard in the other case. IMO, it's more permissible to substitute standard capitalization with uncapitalized version vs. when nonstandard capitalization is specifically and consciously chosen by authors.

audio/carla/Makefile

25

This app is primarily Qt. It uses Gtk in a "secondary" way, only for plugin containers.