Page MenuHomeFreeBSD

VIMAGE PF fixes #4
ClosedPublic

Authored by • rodrigc on Dec 14 2014, 2:54 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Oct 1, 3:23 AM
Unknown Object (File)
Tue, Sep 29, 11:27 PM
Unknown Object (File)
Tue, Sep 22, 9:36 AM
Unknown Object (File)
Mon, Sep 21, 11:12 AM
Unknown Object (File)
Sun, Sep 13, 8:55 AM
Unknown Object (File)
Wed, Sep 9, 7:45 AM
Unknown Object (File)
Tue, Sep 8, 6:06 AM
Unknown Object (File)
Mon, Sep 7, 4:24 PM

Details

Reviewers
• rodrigc
trociny
glebius
bz
zec
Group Reviewers
network
Summary

Instead of creating a purge thread for every vnet, create
a single purge thread and clean up all vnets from this thread.

Test Plan

(1) Boot a kernel with VIMAGE enabled
(2) Create a vnet jail

jail -c persist name=testjail001 vnet path=/ host.hostname=testjail001 allow.raw_sockets allow.socket_af

(3) Start pf inside the jail

service start pf

(4) Delete the vnet jail

jail -r testjail001

Without this patch, the kernel would panic in step (4). With the patch,
the kernel does not panic

Diff Detail

Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

• rodrigc retitled this revision from to VIMAGE PF fixes #4.
• rodrigc updated this object.
• rodrigc edited the test plan for this revision. (Show Details)
• rodrigc added reviewers: bz, glebius, trociny, network.
• rodrigc added subscribers: Unknown Object (MLST), Unknown Object (MLST), Unknown Object (MLST).
zec added inline comments.
sys/netpfil/pf/pf.c
1384

*v could be marked as __unused

sys/netpfil/pf/pf_ioctl.c
282

Passing curvnet as an argument here is redundant now.

This revision is now accepted and ready to land.Jan 6 2015, 9:06 AM