Page MenuHomeFreeBSD

php*-fastdfs: remove hard-code patching
ClosedPublic

Authored by joneum on Nov 17 2017, 8:47 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, Nov 12, 11:42 AM
Unknown Object (File)
Mon, Nov 11, 2:42 PM
Unknown Object (File)
Mon, Nov 11, 6:18 AM
Unknown Object (File)
Mon, Nov 11, 4:45 AM
Unknown Object (File)
Mon, Nov 11, 3:50 AM
Unknown Object (File)
Fri, Nov 1, 3:34 AM
Unknown Object (File)
Thu, Oct 31, 10:08 AM
Unknown Object (File)
Sun, Oct 27, 10:27 PM
Subscribers

Diff Detail

Repository
rP FreeBSD ports repository
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

You probably should not change to DISTVERSION here, as that is the only change to the line

As these set PHP_VER, I do not think they need the IGNORE_WITH_PHP variable, it is useless. (Because what is in PHP_VER is used to check if IGNORE_WITH_PHP matches, so it will never match.)

switch back to PORTVERSION, remove PHP ignore

Ok, I think this is a good first step for these ports.

The next one is to see how you can combine them nicely into one like @tz suggested in revision D13123 :)

Unless @tz has anything to add for now, this seems fine.

This revision is now accepted and ready to land.Nov 24 2017, 11:05 PM
This revision was automatically updated to reflect the committed changes.