Page MenuHomeFreeBSD
Differential D13132

Make OpenEXR optional for KDE ports.
ClosedPublic
Actions

Authored by adridg on Nov 17 2017, 2:20 PM.
Tags
None
Referenced Files
Unknown Object (File)
Mar 11 2024, 6:45 PM
Unknown Object (File)
Feb 2 2024, 12:43 AM
Unknown Object (File)
Feb 2 2024, 12:43 AM
Unknown Object (File)
Feb 2 2024, 12:43 AM
Unknown Object (File)
Feb 2 2024, 12:43 AM
Unknown Object (File)
Feb 2 2024, 12:43 AM
Unknown Object (File)
Jan 30 2024, 8:49 PM
Unknown Object (File)
Jan 14 2024, 2:04 PM
View All 35 Files
Subscribers
mat

Details

Reviewers
tcberner
rakuco
Commits
rP454896: Update KDE ports that use OpenEXR, to use it optionally. This makes
Summary

Because of the planned removal of OpenEXR, make it optional (enabled by
default) so we can easily turn it off if needed.

Diff Detail

Repository
rP FreeBSD ports repository
Lint
No Lint Coverage
Unit
No Test Coverage
Build Status
Buildable 12886
Build 13148: arc lint + arc unit

Event Timeline

adridg created this revision.Nov 17 2017, 2:20 PM
Herald added a subscriber: mat. · View Herald TranscriptNov 17 2017, 2:20 PM
Harbormaster completed remote builds in B12811: Diff 35372.Nov 17 2017, 2:20 PM
tcberner added a comment.Nov 17 2017, 7:37 PM

Thanks for looking at this.

editors/calligra/Makefile
17

No Option?

graphics/kf5-kimageformats/Makefile
18

^possibly missing tab?

x11/kde4-runtime/Makefile
41

^ possibly missing tab

x11/kdelibs4/Makefile
75

^ possibly missing tab?

tcberner added a comment.Nov 17 2017, 10:07 PM

Apart from the [missing?] Option it seems fine.

adridg added inline comments.Nov 20 2017, 10:26 AM
editors/calligra/Makefile
17

I thought Calligra didn't use OpenEXR at all, but I was wrong; this needs an option just like the others.

adridg updated this revision to Diff 35493.Nov 20 2017, 10:50 AM
  • add OPTIONS to editors/calligra
  • add tabs where needed
Harbormaster completed remote builds in B12886: Diff 35493.Nov 20 2017, 10:50 AM
adridg marked 4 inline comments as done.Nov 20 2017, 10:51 AM
adridg marked an inline comment as done.
tcberner accepted this revision.Nov 25 2017, 11:06 AM

OPTIONS_SUB=YES->yes everywhere :)

otherwise it looks good :)

graphics/krita/Makefile
43

^uses 'yes' not 'YES'

This revision is now accepted and ready to land.Nov 25 2017, 11:06 AM
adridg updated this revision to Diff 35776.Nov 25 2017, 8:39 PM

OPTIONS_SUB -> yes (the value is ignored, but "yes" is traditional)

This revision now requires review to proceed.Nov 25 2017, 8:39 PM
Harbormaster completed remote builds in B13058: Diff 35776.Nov 25 2017, 8:39 PM
Closed by commit rP454896: Update KDE ports that use OpenEXR, to use it optionally. This makes (authored by adridg). · Explain WhyNov 25 2017, 8:43 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
editors/
calligra/
10 lines
graphics/
kf5-kimageformats/
11 lines
4 lines
krita/
13 lines
8 lines
x11/
kde4-runtime/
12 lines
4 lines
kdelibs4/
13 lines
4 lines

Diff 35493

View Options

editors/calligra/Makefile

Loading...
View Options

graphics/kf5-kimageformats/Makefile

Loading...
View Options

graphics/kf5-kimageformats/pkg-plist

Loading...
View Options

graphics/krita/Makefile

Loading...
View Options

graphics/krita/pkg-plist

Loading...
View Options

x11/kde4-runtime/Makefile

Loading...
View Options

x11/kde4-runtime/pkg-plist

Loading...
View Options

x11/kdelibs4/Makefile

Loading...
View Options

x11/kdelibs4/pkg-plist

Loading...