Differential D13132

Make OpenEXR optional for KDE ports.
ClosedPublic
Actions

Authored by adridg on Nov 17 2017, 2:20 PM.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Feb 26, 2:27 AM

	Unknown Object (File)
	Mon, Feb 17, 12:00 PM

	Unknown Object (File)
	Wed, Feb 5, 7:40 PM

	Unknown Object (File)
	Feb 2 2025, 11:00 AM

	Unknown Object (File)
	Jan 22 2025, 9:32 PM

	Unknown Object (File)
	Jan 22 2025, 5:32 PM

	Unknown Object (File)
	Jan 18 2025, 11:10 AM

	Unknown Object (File)
	Jan 18 2025, 9:10 AM

View All 96 Files

Subscribers

Details

Reviewers

tcberner
rakuco

Commits

rP454896: Update KDE ports that use OpenEXR, to use it optionally. This makes

Summary

Because of the planned removal of OpenEXR, make it optional (enabled by
default) so we can easily turn it off if needed.

Diff Detail

Repository

rP FreeBSD ports repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

adridg created this revision.Nov 17 2017, 2:20 PM

Herald added a subscriber: mat. · View Herald TranscriptNov 17 2017, 2:20 PM

Harbormaster completed remote builds in B12811: Diff 35372.Nov 17 2017, 2:20 PM

Thanks for looking at this.

editors/calligra/Makefile
17 ↗	(On Diff #35372)	No Option?
graphics/kf5-kimageformats/Makefile
18 ↗	(On Diff #35372)	^possibly missing tab?
x11/kde4-runtime/Makefile
41 ↗	(On Diff #35372)	^ possibly missing tab
x11/kdelibs4/Makefile
75 ↗	(On Diff #35372)	^ possibly missing tab?

Apart from the [missing?] Option it seems fine.

adridg added inline comments.Nov 20 2017, 10:26 AM

editors/calligra/Makefile
17 ↗	(On Diff #35372)	I thought Calligra didn't use OpenEXR at all, but I was wrong; this needs an option just like the others.

add OPTIONS to editors/calligra
add tabs where needed

Harbormaster completed remote builds in B12886: Diff 35493.Nov 20 2017, 10:50 AM

adridg marked 4 inline comments as done.Nov 20 2017, 10:51 AM

adridg marked an inline comment as done.

OPTIONS_SUB=YES->yes everywhere :)

otherwise it looks good :)

graphics/krita/Makefile
43 ↗	(On Diff #35493)	^uses 'yes' not 'YES'

This revision is now accepted and ready to land.Nov 25 2017, 11:06 AM

OPTIONS_SUB -> yes (the value is ignored, but "yes" is traditional)

This revision now requires review to proceed.Nov 25 2017, 8:39 PM

Harbormaster completed remote builds in B13058: Diff 35776.Nov 25 2017, 8:39 PM

Closed by commit rP454896: Update KDE ports that use OpenEXR, to use it optionally. This makes (authored by adridg). · Explain WhyNov 25 2017, 8:43 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

head/

editors/

calligra/

10 lines

graphics/

kf5-kimageformats/

11 lines

4 lines

krita/

11 lines

8 lines

x11/

kde4-runtime/

12 lines

4 lines

kdelibs4/

13 lines

4 lines

Diff 35777

head/editors/calligra/Makefile

Loading...

head/graphics/kf5-kimageformats/Makefile

Loading...

head/graphics/kf5-kimageformats/pkg-plist

Loading...

head/graphics/krita/Makefile

Loading...

head/graphics/krita/pkg-plist

Loading...

head/x11/kde4-runtime/Makefile

Loading...

head/x11/kde4-runtime/pkg-plist

Loading...

head/x11/kdelibs4/Makefile

Loading...

head/x11/kdelibs4/pkg-plist

Loading...