Page MenuHomeFreeBSD

aw_nmi: add support for a83t's r_intc
ClosedPublic

Authored by kevans on Nov 16 2017, 6:41 PM.
Tags
None
Referenced Files
Unknown Object (File)
Apr 26 2024, 9:03 PM
Unknown Object (File)
Dec 23 2023, 5:43 AM
Unknown Object (File)
Dec 22 2023, 11:13 PM
Unknown Object (File)
Nov 25 2023, 7:56 PM
Unknown Object (File)
Nov 23 2023, 12:20 PM
Unknown Object (File)
Nov 22 2023, 1:45 PM
Unknown Object (File)
Nov 22 2023, 1:00 PM
Unknown Object (File)
Nov 13 2023, 1:58 AM
Subscribers

Details

Summary

We currently support the a83t's r_intc in a somewhat hack-ish way; our .dts describes it as nmi_intc, and uses a subset of the actual register space to make it line up with a20/a31 nmi offsets.

This will break with the4.14 update describing r_intc using the full register space, so update aw_nmi to use the correct register offsets with the right compat data in a way that doesn't break our current dts with nmi_intc or upstream with r_intc described.

Diff Detail

Repository
rS FreeBSD src repository - subversion
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

This is also needed for A31/A31s as the binding changed also in 4.14, I'll make the necessary changes for this SoC after this is commited.
Thanks

This revision is now accepted and ready to land.Nov 18 2017, 4:12 PM
sys/arm/allwinner/aw_nmi.c
114 ↗(On Diff #35332)

You can also modify this compatible to be 'allwinner,sun6i-a31-r-intc', A83T fallback on this as they are compatible.

Ping @emaste, can I push this (+ adding a31 r-intc compat w/ a83t_r_nmi_cfg) through tonight?

After @manu's review, you have my approval.

This revision was automatically updated to reflect the committed changes.